threads / discuss / 20073

found another resource leak in file xdiff-interface.c

Subject: found another resource leak in file xdiff-interface.c

## tl;dr

One message between Jul 10, 2009 and Jul 10, 2009.

replies: 0people: 1as markdown or json

Martin Ettl· Jul 10, 2009, 07:47 UTC · lore
Hi friends,
i have detected another resource leak (using the static code analysis tool cppcheck) in file xdiff-interface.c.
The tool prints the following warning:
[git.1.6.3.3/xdiff-interface.c:215](error) resource leak f
int read_mmfile(mmfile_t *ptr, const char *filename)
{
//...
	if (sz && fread(ptr->ptr, sz, 1, f) != 1)
		return error("Could not read %s", filename);
	fclose(f);
// ....
	ptr->size = sz;
	return 0;
}
A possible solution might be:
int read_mmfile(mmfile_t *ptr, const char *filename)
{
//...
	if (sz && fread(ptr->ptr, sz, 1, f) != 1)
        {
	        fclose(f);
		return error("Could not read %s", filename);
        }
	fclose(f);
// ....
	ptr->size = sz;
	return 0;
}
Best regards
Ettl Martin
-- 
GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01

← back to recent threads