[PATCH] Failing test; renaming sections can lose assignments on the same line

Alex Vandiver· Jul 8, 2009, 20:40 UTC · lore

Signed-off-by: Alex Vandiver <alex@chmrr.net>
---

I noticed the following bug recently:

    echo "[foo] x = 1" > testfile
    git config --file=testfile --rename-section foo bar
    cat testfile
    # [bar]

This is at least a failing test, and I'll look at how complex the fix is when I get a few spare tuits.

 t/t1300-repo-config.sh |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)

Show changes to t/t1300-repo-config.sh +21 −0

diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
index 43ea283..4d576c6 100755
--- a/t/t1300-repo-config.sh
+++ b/t/t1300-repo-config.sh
@@ -460,6 +460,27 @@ EOF
 test_expect_success "rename succeeded" "test_cmp expect .git/config"
 
 cat >> .git/config << EOF
+[branch "vier"] z = 1
+EOF
+
+test_expect_success "rename a section with a var on the same line" \
+	'git config --rename-section branch.vier branch.zwei'
+
+cat > expect << EOF
+# Hallo
+	#Bello
+[branch "zwei"]
+	x = 1
+[branch "zwei"]
+	y = 1
+[branch "drei"]
+weird
+[branch "zwei"] z = 1
+EOF
+
+test_expect_success "rename succeeded" "test_cmp expect .git/config"
+
+cat >> .git/config << EOF
   [branch "zwei"] a = 1 [branch "vier"]
 EOF

-- 
1.6.3.3.473.gb74fc4.dirty

patchFailing test; renaming sections can lose assignments on the same line