threads / patch / 20034

patch, 2 partsRemove archaic use of regex capture \1 in favour of $1

Subject: [PATCH 1/2] Remove archaic use of regex capture \1 in favour of $1

## tl;dr

One message between Jul 6, 2009 and Jul 6, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nick Woolley· Jul 6, 2009, 13:33 UTC · lore
Using it will generate a perl warning "\1 better written as $1".
Signed-off-by: Nick Woolley <git.wu-lee@noodlefactory.co.uk>
---
 git-cvsexportcommit.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-cvsexportcommit.perl +1 −1
diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index a36df33..d509468 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -299,7 +299,7 @@ foreach my $f (@files) {
 	while (<FILTER_IN>)
 	{
 	    my $line = $_;
-	    $line =~ s/\$([A-Z][a-z]+):[^\$]+\$/\$\1\$/g;
+	    $line =~ s/\$([A-Z][a-z]+):[^\$]+\$/\$$1\$/g;
 	    print FILTER_OUT $line;
 	}
 	close FILTER_IN;
-- 
1.6.3.3

← back to recent threads