threads / patch / 19993

patchBlobBasedConfig now does not print stacktrace to stderr if blob is not found by path

Subject: [JGIT PATCH] BlobBasedConfig now does not print stacktrace to stderr if blob is not found by path

## tl;dr

One message between Jul 1, 2009 and Jul 1, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Constantine Plotnikov· Jul 1, 2009, 17:25 UTC · lore

Prior to this patch, if the blob is not found inside commit by path, an exception stack trace was printed to stderr. This patch suppress this behavior by throwing FileNotFoundException instead of generic IOException in order to make it more aligned with FileBasedConfig.

Signed-off-by: Constantine Plotnikov <constantine.plotnikov@gmail.com>
---
 .../src/org/spearce/jgit/lib/BlobBasedConfig.java  |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Show changes to org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java +2 −1
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java b/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java
index 1f44994..8763c6c 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/BlobBasedConfig.java
@@ -37,6 +37,7 @@
 package org.spearce.jgit.lib;
 
 import java.io.ByteArrayInputStream;
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
 import java.util.concurrent.Callable;
@@ -118,7 +119,7 @@ this(base, new Callable<byte[]>() {
 				final Repository r = commit.getRepository();
 				final TreeWalk tree = TreeWalk.forPath(r, path, treeId);
 				if (tree == null) {
-					throw new IOException("Entry not found by path: " + path);
+					throw new FileNotFoundException("Entry not found by path: " + path);
 				}
 				ObjectId blobId = tree.getObjectId(0);
 				ObjectLoader loader = tree.getRepository().openBlob(blobId);
-- 
1.6.1.2

← back to recent threads