# [PATCH] http-push: fix xml_entities() string parsing overrun 1 messages from 2009-07-01 to 2009-07-01. Participants: Hunter, D. Seth. Thread: https://gitlist.dev/t/19989 ## Hunter, D. Seth, 2009-07-01 00:24 Subject: [PATCH] http-push: fix xml_entities() string parsing overrun Message-ID: URL: https://gitlist.dev/e/D7CBF77D2B9C1D4D8C5E528FBBB35D8B58EC70ECDA%40LLE2K7-BE02.mitll.ad.local ``` xml_entities() in http-push.c did not properly stop at the end of the string being examined, which would occasionally cause nonsense to be appended to escaped URL strings and result in failed DAV XML queries Signed-off-by: Seth Hunter --- http-push.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/http-push.c b/http-push.c index 8cc8ee0..00e83dc 100644 --- a/http-push.c +++ b/http-push.c @@ -193,6 +193,8 @@ static char *xml_entities(char *s) case '&': strbuf_addstr(&buf, "&"); break; + case 0: + return strbuf_detach(&buf, NULL); } s++; } -- 1.6.3.3 ```