# [PATCH] completion: __git_config_get_set_variables() handle values with spaces 2 messages from 2009-06-30 to 2009-07-02. Participants: Stephen Boyd. Thread: https://gitlist.dev/t/19976 ## Stephen Boyd, 2009-06-30 05:08 Subject: [PATCH] completion: __git_config_get_set_variables() handle values with spaces Message-ID: <1246338518-9030-1-git-send-email-bebarino@gmail.com> URL: https://gitlist.dev/e/1246338518-9030-1-git-send-email-bebarino%40gmail.com ``` Commit 0065236 (bash completion: complete variable names for "git config" with options 2009-05-08) implemented its config variable search wrong. When a config contains a value with a space and a period (.) in it, completion erroneously thinks that line in the configuration is multiple config variables. For example $ cat .git/config format.cc = Junio C Hamano $ git config --unset format.cc Instead of using a for loop splitting across spaces, pipe each line to a while read loop and beef up the case statement to match only 'config.variable=value'. Signed-off-by: Stephen Boyd --- contrib/completion/git-completion.bash | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index b60cb68..d676f9d 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1357,11 +1357,12 @@ __git_config_get_set_variables () c=$((--c)) done - for i in $(git --git-dir="$(__gitdir)" config $config_file --list \ - 2>/dev/null); do - case "$i" in - *.*) - echo "${i/=*/}" + git --git-dir="$(__gitdir)" config $config_file --list 2>/dev/null | + while read line + do + case "$line" in + *.*=*) + echo "${line/=*/}" ;; esac done -- 1.6.3.3.353.g4f2b1 ``` ## Stephen Boyd, 2009-07-02 06:04 Subject: Re: [PATCH] completion: __git_config_get_set_variables() handle values with spaces Message-ID: <4A4C4DD7.7030801@gmail.com> URL: https://gitlist.dev/e/4A4C4DD7.7030801%40gmail.com In-Reply-To: <1246338518-9030-1-git-send-email-bebarino@gmail.com> ``` Stephen Boyd wrote: > For example > > $ cat .git/config > format.cc = Junio C Hamano > Sorry this is inaccurate. Something more like $ cat .git/config [format] cc = Junio C Hamano would be correct, but I think you got the point. ```