threads / discuss / 19967

Merge, rebase and whitespace fixes

Subject: Merge, rebase and whitespace fixes

## tl;dr

5 messages between Jun 29, 2009 and Jun 30, 2009.

replies: 4people: 2as markdown or json

Giuseppe Bilotta· Jun 29, 2009, 19:18 UTC · lore
Hello all,

recently a tree I've been working on received some thorough whitespace adjustments (changing indents from spaces to tabs). This results in annoying conflicts when running merges or rebases with my local branches. I tried googling around but I couldn't find any helpful hints on how to make git cope with this. Any suggestions?

-- 
Giuseppe "Oblomov" Bilotta
Rogan Dawes· Jun 29, 2009, 21:30 UTC · re: Giuseppe Bilotta · lore

Re: Merge, rebase and whitespace fixes

Giuseppe Bilotta wrote:
Show 8 quoted lines
> Hello all,
> 
> recently a tree I've been working on received some thorough whitespace
> adjustments (changing indents from spaces to tabs). This results in
> annoying conflicts when running merges or rebases with my local
> branches. I tried googling around but I couldn't find any helpful
> hints on how to make git cope with this. Any suggestions?
> 
Do the same thing to your own tree?
Giuseppe Bilotta· Jun 30, 2009, 07:37 UTC · re: Rogan Dawes · lore

Re: Merge, rebase and whitespace fixes

On Mon, Jun 29, 2009 at 11:30 PM, Rogan Dawes<lists@dawes.za.net> wrote:
Show 11 quoted lines
> Giuseppe Bilotta wrote:
>> Hello all,
>>
>> recently a tree I've been working on received some thorough whitespace
>> adjustments (changing indents from spaces to tabs). This results in
>> annoying conflicts when running merges or rebases with my local
>> branches. I tried googling around but I couldn't find any helpful
>> hints on how to make git cope with this. Any suggestions?
>>
>
> Do the same thing to your own tree?

I tried doing the whitespace cleanup on top of the last patch, but the merge still conflicted.

The interesting thing is that there's patchset from Robert Fitzsimons that goes back to August 2005 (!) that does a couple of git apply cleanups and in particular adds the --ignore-whitespace option that I would need ...

http://permalink.gmane.org/gmane.comp.version-control.git/7876
but the patch apparently never made it into mainline ...
-- 
Giuseppe "Oblomov" Bilotta
Rogan Dawes· Jun 30, 2009, 09:03 UTC · re: Giuseppe Bilotta · lore

Re: Merge, rebase and whitespace fixes

Giuseppe Bilotta wrote:
Show 24 quoted lines
> On Mon, Jun 29, 2009 at 11:30 PM, Rogan Dawes<lists@dawes.za.net> wrote:
>> Giuseppe Bilotta wrote:
>>> Hello all,
>>>
>>> recently a tree I've been working on received some thorough whitespace
>>> adjustments (changing indents from spaces to tabs). This results in
>>> annoying conflicts when running merges or rebases with my local
>>> branches. I tried googling around but I couldn't find any helpful
>>> hints on how to make git cope with this. Any suggestions?
>>>
>> Do the same thing to your own tree?
> 
> I tried doing the whitespace cleanup on top of the last patch, but the
> merge still conflicted.
> 
> The interesting thing is that there's patchset from Robert Fitzsimons
> that goes back to August 2005 (!) that does a couple of git apply
> cleanups and in particular adds the --ignore-whitespace option that I
> would need ...
> 
> http://permalink.gmane.org/gmane.comp.version-control.git/7876
> 
> but the patch apparently never made it into mainline ...
> 

One thing I have done in the past when trying to merge two diverged trees was to format each commit in each tree to a common standard.

One of the ways in which the trees had diverged was whitespace (non-meaningful) changes, so I used the Eclipse formatter as part of a "git filter-branch" script to make sure that I was ony looking at meaningful changes between the trees at each point. This significantly simplified the process.

Rogan
Giuseppe Bilotta· Jun 30, 2009, 09:18 UTC · re: Rogan Dawes · lore

Re: Merge, rebase and whitespace fixes

On Tue, Jun 30, 2009 at 11:03 AM, Rogan Dawes<lists@dawes.za.net> wrote:
Show 21 quoted lines
>> I tried doing the whitespace cleanup on top of the last patch, but the
>> merge still conflicted.
>>
>> The interesting thing is that there's patchset from Robert Fitzsimons
>> that goes back to August 2005 (!) that does a couple of git apply
>> cleanups and in particular adds the --ignore-whitespace option that I
>> would need ...
>>
>> http://permalink.gmane.org/gmane.comp.version-control.git/7876
>>
>> but the patch apparently never made it into mainline ...
>>
>
> One thing I have done in the past when trying to merge two diverged
> trees was to format each commit in each tree to a common standard.
>
> One of the ways in which the trees had diverged was whitespace
> (non-meaningful) changes, so I used the Eclipse formatter as part of a
> "git filter-branch" script to make sure that I was ony looking at
> meaningful changes between the trees at each point. This significantly
> simplified the process.

I can also reply all the patches manually, of course, but the question is: why should I be doing something manually when it can be done programmatically?

BTW, I tried updating Robert's patch to the new code base, but it's WAY too different ...

-- 
Giuseppe "Oblomov" Bilotta

← back to recent threads