threads / patch / 19901

patcht/t9001-send-email.sh: ensure generated script is executed with $SHELL_PATH

Subject: [PATCH] t/t9001-send-email.sh: ensure generated script is executed with $SHELL_PATH

## tl;dr

One message between Jun 22, 2009 and Jun 22, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Brandon Casey· Jun 22, 2009, 17:32 UTC · lore
From: Brandon Casey <drafnel@gmail.com>

If the shell is not specified using the '#!' notation, then the OS will use '/bin/sh' to execute the script which may not produce the desired results. In particular, /bin/sh on Solaris interprets '^' specially which has an affect on the sed command that this patch touches.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
 t/t9001-send-email.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Show changes to t/t9001-send-email.sh +3 −1
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index fb7d9f3..7b4cf55 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -152,7 +152,9 @@ test_expect_success 'cccmd works' '
 	clean_fake_sendmail &&
 	cp $patches cccmd.patch &&
 	echo cccmd--cccmd@example.com >>cccmd.patch &&
-	echo sed -n s/^cccmd--//p \"\$1\" > cccmd-sed &&
+	{ echo "#!$SHELL_PATH"
+	  echo sed -n s/^cccmd--//p \"\$1\"
+	} > cccmd-sed &&
 	chmod +x cccmd-sed &&
 	git send-email \
 		--from="Example <nobody@example.com>" \
-- 
1.6.3.1.24.g152f4

← back to recent threads