[JGIT PATCH] Remove System.out.println from RevWalkFilterTest

Shawn O. Pearce· Jun 16, 2009, 23:35 UTC · lore

JUnit tests shouldn't (in general) print to System.out, we already have too much flooding the console when running a full test suite. Instead assertions should be relied upon, which these tests already have.

CC: Mark Struberg <struberg@yahoo.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../spearce/jgit/revwalk/RevWalkFilterTest.java    |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Show changes to org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java +0 −3

diff --git a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
index e2c813a..5aa648a 100644
--- a/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
+++ b/org.spearce.jgit.test/tst/org/spearce/jgit/revwalk/RevWalkFilterTest.java
@@ -241,7 +241,6 @@ public void testCommitTimeRevFilter() throws Exception {
 		{
 			RevFilter after = CommitTimeRevFilter.after(since);
 			assertNotNull(after);
-			System.out.println(after.toString());
 			rw.setRevFilter(after);
 			markStart(e);
 			assertCommit(e, rw.next());
@@ -254,7 +253,6 @@ public void testCommitTimeRevFilter() throws Exception {
 		{
 			RevFilter before = CommitTimeRevFilter.before(until);
 			assertNotNull(before);
-			System.out.println(before.toString());
 			rw.reset();
 			rw.setRevFilter(before);
 			markStart(e);
@@ -268,7 +266,6 @@ public void testCommitTimeRevFilter() throws Exception {
 		{
 			RevFilter between = CommitTimeRevFilter.between(since, until);
 			assertNotNull(between);
-			System.out.println(between.toString());
 			rw.reset();
 			rw.setRevFilter(between);
 			markStart(e);

-- 
1.6.3.2.406.gd6a466

patchRemove System.out.println from RevWalkFilterTest