# [PATCH] pull, rebase: simplify to use die()

1 messages from 2009-06-14 to 2009-06-14. Participants: Stephen Boyd.
Thread: https://gitlist.dev/t/19814

## Stephen Boyd, 2009-06-14 23:08

Subject: [PATCH] pull, rebase: simplify to use die()
Message-ID: <1245020936-7978-1-git-send-email-bebarino@gmail.com>
URL: https://gitlist.dev/e/1245020936-7978-1-git-send-email-bebarino%40gmail.com

```
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---

I noticed these, and they're somewhat unrelated from the quiet
stuff.

 git-pull.sh   |    6 ++----
 git-rebase.sh |    9 +++------
 2 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/git-pull.sh b/git-pull.sh
index 3526153..cab367a 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -176,13 +176,11 @@ case "$merge_head" in
 ?*' '?*)
 	if test -z "$orig_head"
 	then
-		echo >&2 "Cannot merge multiple branches into empty head"
-		exit 1
+		die "Cannot merge multiple branches into empty head"
 	fi
 	if test true = "$rebase"
 	then
-		echo >&2 "Cannot rebase onto multiple branches"
-		exit 1
+		die "Cannot rebase onto multiple branches"
 	fi
 	;;
 esac
diff --git a/git-rebase.sh b/git-rebase.sh
index b83fd3f..334629f 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -168,10 +168,8 @@ run_pre_rebase_hook () {
 	if test -z "$OK_TO_SKIP_PRE_REBASE" &&
 	   test -x "$GIT_DIR/hooks/pre-rebase"
 	then
-		"$GIT_DIR/hooks/pre-rebase" ${1+"$@"} || {
-			echo >&2 "The pre-rebase hook refused to rebase."
-			exit 1
-		}
+		"$GIT_DIR/hooks/pre-rebase" ${1+"$@"} ||
+		die "The pre-rebase hook refused to rebase."
 	fi
 }
 
@@ -359,8 +357,7 @@ fi
 
 # The tree must be really really clean.
 if ! git update-index --ignore-submodules --refresh; then
-	echo >&2 "cannot rebase: you have unstaged changes"
-	exit 1
+	die "cannot rebase: you have unstaged changes"
 fi
 diff=$(git diff-index --cached --name-status -r --ignore-submodules HEAD --)
 case "$diff" in
-- 
1.6.3.2.306.g4f4fa

```