threads / patch / 19798

patchDocumentation: remove warning that "git bisect skip" may slow bisection

Subject: [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection

## tl;dr

3 messages between Jun 13, 2009 and Jun 13, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Christian Couder· Jun 13, 2009, 05:22 UTC · lore

This warning was probably useless anyway, but it is even more so now that filtering of skipped commits is done in C and that there is a mechanism to skip away from broken commits.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 Documentation/git-bisect.txt |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Show changes to Documentation/git-bisect.txt +2 −3
diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt
index ffc02c7..5d015fc 100644
--- a/Documentation/git-bisect.txt
+++ b/Documentation/git-bisect.txt
@@ -164,9 +164,8 @@ to do it for you by issuing the command:
 $ git bisect skip                 # Current version cannot be tested
 ------------
 
-But computing the commit to test may be slower afterwards and git may
-eventually not be able to tell the first bad commit among a bad commit
-and one or more skipped commits.
+But git may eventually not be able to tell the first bad commit among
+a bad commit and one or more skipped commits.
 
 You can even skip a range of commits, instead of just one commit,
 using the "'<commit1>'..'<commit2>'" notation. For example:

-- 
1.6.3.GIT
Stephen Boyd· Jun 13, 2009, 08:14 UTC · re: Christian Couder · lore

Re: [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection

Christian Couder wrote:
Show 9 quoted lines
> -But computing the commit to test may be slower afterwards and git may
> -eventually not be able to tell the first bad commit among a bad commit
> -and one or more skipped commits.
> +But git may eventually not be able to tell the first bad commit among
> +a bad commit and one or more skipped commits.
>  
>  You can even skip a range of commits, instead of just one commit,
>  using the "'<commit1>'..'<commit2>'" notation. For example:
>   
Can this be "git may eventually be unable to tell" instead?
Christian Couder· Jun 13, 2009, 11:13 UTC · re: Stephen Boyd · lore

Re: [PATCH] Documentation: remove warning that "git bisect skip" may slow bisection

Le Saturday 13 June 2009, Stephen Boyd a écrit :
Show 11 quoted lines
> Christian Couder wrote:
> > -But computing the commit to test may be slower afterwards and git may
> > -eventually not be able to tell the first bad commit among a bad commit
> > -and one or more skipped commits.
> > +But git may eventually not be able to tell the first bad commit among
> > +a bad commit and one or more skipped commits.
> >
> >  You can even skip a range of commits, instead of just one commit,
> >  using the "'<commit1>'..'<commit2>'" notation. For example:
>
> Can this be "git may eventually be unable to tell" instead?
Yes, I just sent a v2 with this change.

Thanks, Christian.

← back to recent threads