# [PATCH] Make logerror() and loginfo() static

2 messages from 2005-09-29 to 2005-09-30. Participants: Pavel Roskin, Junio C Hamano.
Thread: https://gitlist.dev/t/1978

## Pavel Roskin, 2005-09-29 20:53

Subject: [PATCH] Make logerror() and loginfo() static
Message-ID: <1128027194.24397.50.camel@dv>
URL: https://gitlist.dev/e/1128027194.24397.50.camel%40dv

```
Make logerror() and loginfo() static

logerror() and loginfo() in daemon.c are never declared and never called
from other files, therefore they should be declared static.  Found by
sparse.

Signed-off-by: Pavel Roskin <proski@gnu.org>

diff --git a/daemon.c b/daemon.c
--- a/daemon.c
+++ b/daemon.c
@@ -57,7 +57,7 @@ static void logreport(int priority, cons
 	write(2, buf, buflen);
 }
 
-void logerror(const char *err, ...)
+static void logerror(const char *err, ...)
 {
 	va_list params;
 	va_start(params, err);
@@ -65,7 +65,7 @@ void logerror(const char *err, ...)
 	va_end(params);
 }
 
-void loginfo(const char *err, ...)
+static void loginfo(const char *err, ...)
 {
 	va_list params;
 	if (!verbose)


-- 
Regards,
Pavel Roskin

```

## Junio C Hamano, 2005-09-30 05:50

Subject: Re: [PATCH] Make logerror() and loginfo() static
Message-ID: <7v64sj9kab.fsf@assigned-by-dhcp.cox.net>
URL: https://gitlist.dev/e/7v64sj9kab.fsf%40assigned-by-dhcp.cox.net
In-Reply-To: <1128027194.24397.50.camel@dv>

```
Thanks.  Will apply.

Next time around, please CC me (or To me and CC list), if the
patch is trivial and for immediate application.

```