# mkstemps compat issue

3 messages from 2009-06-07 to 2009-06-08. Participants: Andreas Färber, David Aguilar.
Thread: https://gitlist.dev/t/19723

## Andreas Färber, 2009-06-07 12:32

Subject: mkstemps compat issue
Message-ID: <ED882BBA-E0E7-4CCC-9C6B-72FEBED1C9E0@web.de>
URL: https://gitlist.dev/e/ED882BBA-E0E7-4CCC-9C6B-72FEBED1C9E0%40web.de

```
Hello,

The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced a  
git_mkstemps function in path.c, using mkstemps for the  
implementation. Unlike mkstemp that function is not part of POSIX, so  
we seem to need a NO_MKSTEMPS option and corresponding alternative  
code path.

Any suggestions how to best replace mkstemps?

Thanks,
Andreas

[Please keep me cc'ed.]

```

## Andreas Färber, 2009-06-07 12:49

Subject: Re: mkstemps compat issue
Message-ID: <DAD17464-336A-451A-AEFE-26481D6B39B2@web.de>
URL: https://gitlist.dev/e/DAD17464-336A-451A-AEFE-26481D6B39B2%40web.de
In-Reply-To: <ED882BBA-E0E7-4CCC-9C6B-72FEBED1C9E0@web.de>

```

Am 07.06.2009 um 14:32 schrieb Andreas Färber:

> The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced  
> a git_mkstemps function in path.c, using mkstemps for the  
> implementation. Unlike mkstemp that function is not part of POSIX,  
> so we seem to need a NO_MKSTEMPS option and corresponding  
> alternative code path.
>
> Any suggestions how to best replace mkstemps?

Sorry for the noise... NO_MKSTEMPS=YesPlease does work correctly if  
typed correctly. (Thanks for the hint!)

It was a little confusing seeing mkstemps being used unconditionally  
in path.c, but it's being #defined in git-compat-util.h, so everything  
is fine.

Regards,

Andreas

```

## David Aguilar, 2009-06-08 01:13

Subject: Re: mkstemps compat issue
Message-ID: <20090608011334.GA5974@gmail.com>
URL: https://gitlist.dev/e/20090608011334.GA5974%40gmail.com
In-Reply-To: <DAD17464-336A-451A-AEFE-26481D6B39B2@web.de>

```
On Sun, Jun 07, 2009 at 02:49:16PM +0200, Andreas Färber wrote:
>
> Am 07.06.2009 um 14:32 schrieb Andreas Färber:
>
>> The merge commit b11cf09043f18b368ec0d988f064ea21247c843d introduced a 
>> git_mkstemps function in path.c, using mkstemps for the  
>> implementation. Unlike mkstemp that function is not part of POSIX, so 
>> we seem to need a NO_MKSTEMPS option and corresponding alternative code 
>> path.
>>
>> Any suggestions how to best replace mkstemps?
>
> Sorry for the noise... NO_MKSTEMPS=YesPlease does work correctly if  
> typed correctly. (Thanks for the hint!)

Thanks for keeping an eye on it.

I'm still keeping my eye on the patch that introduced the
basename() compat function to see if we missed any Makefile
settings for the non-linux platforms.  We support a lot of
platforms! =)


-- 

	David

```