threads / patch / 19692

patch, 23 partshttp.c::http_fetch_ref(): use the new http API

Subject: [PATCH 17/23] http.c::http_fetch_ref(): use the new http API

## tl;dr

4 messages between Jun 5, 2009 and Jun 6, 2009. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Tay Ray Chuan· Jun 5, 2009, 16:05 UTC · lore

From:	Mike Hommey <mh@glandium.org>
Subject: [WIP Patch 04/12] Use the new http API in http_fetch_ref()
Date:	Sun, 18 Jan 2009 09:04:29 +0100

The error message ("Unable to start request") has been removed, since the http API already prints it.

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 http.c |   33 ++++++++-------------------------
 1 files changed, 8 insertions(+), 25 deletions(-)

Show changes to http.c +8 −26

diff --git a/http.c b/http.c
index df22180..2a49372 100644
--- a/http.c
+++ b/http.c
@@ -773,34 +773,17 @@ int http_fetch_ref(const char *base, struct ref *ref)
 {
 	char *url;
 	struct strbuf buffer = STRBUF_INIT;
-	struct active_request_slot *slot;
-	struct slot_results results;
-	int ret;
+	int ret = -1;

 	url = quote_ref_url(base, ref->name);
-	slot = get_active_slot();
-	slot->results = &results;
-	curl_easy_setopt(slot->curl, CURLOPT_FILE, &buffer);
-	curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
-	curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL);
-	curl_easy_setopt(slot->curl, CURLOPT_URL, url);
-	if (start_active_slot(slot)) {
-		run_active_slot(slot);
-		if (results.curl_result == CURLE_OK) {
-			strbuf_rtrim(&buffer);
-			if (buffer.len == 40)
-				ret = get_sha1_hex(buffer.buf, ref->old_sha1);
-			else if (!prefixcmp(buffer.buf, "ref: ")) {
-				ref->symref = xstrdup(buffer.buf + 5);
-				ret = 0;
-			} else
-				ret = 1;
-		} else {
-			ret = error("Couldn't get %s for %s\n%s",
-				    url, ref->name, curl_errorstr);
+	if (http_get_strbuf(url, &buffer, HTTP_NO_CACHE) == HTTP_OK) {
+		strbuf_rtrim(&buffer);
+		if (buffer.len == 40)
+			ret = get_sha1_hex(buffer.buf, ref->old_sha1);
+		else if (!prefixcmp(buffer.buf, "ref: ")) {
+			ref->symref = xstrdup(buffer.buf + 5);
+			ret = 0;
 		}
-	} else {
-		ret = error("Unable to start request");
 	}

 	strbuf_release(&buffer);
--
1.6.3.1

Jakub Narebski· Jun 5, 2009, 20:50 UTC · re: Tay Ray Chuan · lore

Re: [PATCH 17/23] http.c::http_fetch_ref(): use the new http API

Tay Ray Chuan <rctay89@gmail.com> writes:

> From:	Mike Hommey <mh@glandium.org>
> Subject: [WIP Patch 04/12] Use the new http API in http_fetch_ref()

What is the subject of this patch:
  "http.c::http_fetch_ref(): use the new http API"
or
  "Use the new http API in http_fetch_ref()"

Perhaps this and previous patch should be squashed?

Show 61 quoted lines

> Date:	Sun, 18 Jan 2009 09:04:29 +0100
> 
> The error message ("Unable to start request") has been removed, since
> the http API already prints it.
> 
> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
> ---
>  http.c |   33 ++++++++-------------------------
>  1 files changed, 8 insertions(+), 25 deletions(-)
> 
> diff --git a/http.c b/http.c
> index df22180..2a49372 100644
> --- a/http.c
> +++ b/http.c
> @@ -773,34 +773,17 @@ int http_fetch_ref(const char *base, struct ref *ref)
>  {
>  	char *url;
>  	struct strbuf buffer = STRBUF_INIT;
> -	struct active_request_slot *slot;
> -	struct slot_results results;
> -	int ret;
> +	int ret = -1;
> 
>  	url = quote_ref_url(base, ref->name);
> -	slot = get_active_slot();
> -	slot->results = &results;
> -	curl_easy_setopt(slot->curl, CURLOPT_FILE, &buffer);
> -	curl_easy_setopt(slot->curl, CURLOPT_WRITEFUNCTION, fwrite_buffer);
> -	curl_easy_setopt(slot->curl, CURLOPT_HTTPHEADER, NULL);
> -	curl_easy_setopt(slot->curl, CURLOPT_URL, url);
> -	if (start_active_slot(slot)) {
> -		run_active_slot(slot);
> -		if (results.curl_result == CURLE_OK) {
> -			strbuf_rtrim(&buffer);
> -			if (buffer.len == 40)
> -				ret = get_sha1_hex(buffer.buf, ref->old_sha1);
> -			else if (!prefixcmp(buffer.buf, "ref: ")) {
> -				ref->symref = xstrdup(buffer.buf + 5);
> -				ret = 0;
> -			} else
> -				ret = 1;
> -		} else {
> -			ret = error("Couldn't get %s for %s\n%s",
> -				    url, ref->name, curl_errorstr);
> +	if (http_get_strbuf(url, &buffer, HTTP_NO_CACHE) == HTTP_OK) {
> +		strbuf_rtrim(&buffer);
> +		if (buffer.len == 40)
> +			ret = get_sha1_hex(buffer.buf, ref->old_sha1);
> +		else if (!prefixcmp(buffer.buf, "ref: ")) {
> +			ref->symref = xstrdup(buffer.buf + 5);
> +			ret = 0;
>  		}
> -	} else {
> -		ret = error("Unable to start request");
>  	}
> 
>  	strbuf_release(&buffer);
> --
> 1.6.3.1
>

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Tay Ray Chuan· Jun 6, 2009, 01:04 UTC · re: Jakub Narebski · lore

Re: [PATCH 17/23] http.c::http_fetch_ref(): use the new http API

Hi,

On Sat, Jun 6, 2009 at 4:50 AM, Jakub Narebski<jnareb@gmail.com> wrote:

Show 7 quoted lines

>> From: Mike Hommey <mh@glandium.org>
>> Subject: [WIP Patch 04/12] Use the new http API in http_fetch_ref()
>
> What is the subject of this patch:
>  "http.c::http_fetch_ref(): use the new http API"
> or
>  "Use the new http API in http_fetch_ref()"

See my reply for patch #12.

> Perhaps this and previous patch should be squashed?

Why should this and patch #16 (for get_refs_via_curl()) be squashed? Are you perhaps suggesting that all the use-the-new-http-API patches should be squashed?

-- 
Cheers,
Ray Chuan

Jakub Narebski· Jun 6, 2009, 07:17 UTC · re: Tay Ray Chuan · lore

Re: [PATCH 17/23] http.c::http_fetch_ref(): use the new http API

On Sat, 6 Jun 2009, Tay Ray Chuan wrote:

> On Sat, Jun 6, 2009 at 4:50 AM, Jakub Narebski<jnareb@gmail.com> wrote:

[...]

Show 5 quoted lines

> > Perhaps this and previous patch should be squashed?
> 
> Why should this and patch #16 (for get_refs_via_curl()) be squashed?
> Are you perhaps suggesting that all the use-the-new-http-API patches
> should be squashed?

I'm sorry this was before I noticed that there are a few more patches which are about using newly introduced API. Please disregard this part of message.

-- 
Jakub Narebski
Poland