threads / patch / 19679

patch, 23 partshttp*: refactor (v5)

Subject: [PATCH 00/23] http*: refactor (v5)

## tl;dr

3 messages between Jun 5, 2009 and Jun 6, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Tay Ray Chuan· Jun 5, 2009, 15:59 UTC · lore
Junio, this replaces the entire rc/http-push topic.
Changes from the previous patch series:
- fix return values of fetch_indices() in http-push.c, as highlighted
  by Clemens (patch #20)
- added set slot->local to NULL patch (patch #3)
- set slot->local to NULL in http.c::http_request() (patch #15)
- set slot->local to NULL in http.c::release_http_pack_request() and
  http.c::finish_http_pack_request() (patch #22)
Christian Couder (1):
  http-push: fix missing "#ifdef USE_CURL_MULTI" around
    "is_running_queue"
Mike Hommey (7):
  Don't expect verify_pack() callers to set pack_size
  transport.c::get_refs_via_curl(): do not leak refs_url
  http.c: new functions for the http API
  transport.c::get_refs_via_curl(): use the new http API
  http.c::http_fetch_ref(): use the new http API
  http-push.c::remote_exists(): use the new http API
  http-push.c::fetch_symref(): use the new http API
Tay Ray Chuan (15):
  t5540-http-push: test fetching of loose objects
  t5540-http-push: test fetching of packed objects
  http*: cleanup slot->local after fclose
  http-push: send out fetch requests on queue
  t5550-http-fetch: test fetching of packed objects
  http-push, http-walker: style fixes
  http-walker: verify remote packs
  http*: copy string returned by sha1_to_hex
  http-push: do not SEGV after fetching a bad pack idx file
  http*: move common variables and macros to http.[ch]
  http: create function end_url_with_slash
  http*: add http_get_info_packs
  http: use new http API in fetch_index()
  http*: add helper methods for fetching packs
  http*: add helper methods for fetching objects (loose)
 http-push.c           |  579 ++++++++---------------------------------------
 http-walker.c         |  533 +++++++------------------------------------
 http.c                |  601 +++++++++++++++++++++++++++++++++++++++++++++++--
 http.h                |   85 +++++++
 pack-check.c          |    8 +-
 t/t5540-http-push.sh  |   36 +++
 t/t5550-http-fetch.sh |    8 +
 transport.c           |   33 +--
 8 files changed, 902 insertions(+), 981 deletions(-)
Jakub Narebski· Jun 5, 2009, 20:41 UTC · re: Tay Ray Chuan · lore

Re: [PATCH 00/23] http*: refactor (v5)

Could you please make all patches in this series to be replies to this cover letter ('shallow' threading)? This way it would be easier to read this patch series (or kill / ignore it as a whole)?

Thanks in advance
P.S. Why subject is "Re: [PATCH 00/23] ..." and not "[PATCH 00/23] ..."?
-- 
Jakub Narebski
Poland
ShadeHawk on #git
Tay Ray Chuan· Jun 6, 2009, 01:12 UTC · re: Jakub Narebski · lore

Re: [PATCH 00/23] http*: refactor (v5)

Hi,
On Sat, Jun 6, 2009 at 4:41 AM, Jakub Narebski<jnareb@gmail.com> wrote:
Show 5 quoted lines
> Could you please make all patches in this series to be replies to this
> cover letter ('shallow' threading)?  This way it would be easier to
> read this patch series (or kill / ignore it as a whole)?
>
> Thanks in advance
I'll keep that in mind.
> P.S. Why subject is "Re: [PATCH 00/23] ..." and not "[PATCH 00/23] ..."?
Hmm, I've checked gmane and elsewhere, the subject says "[PATCH 00/23]..."...
-- 
Cheers,
Ray Chuan

← back to recent threads