threads / patch / 19652

patchSend non-standard port in host header of git://

Subject: [JGIT PATCH] Send non-standard port in host header of git://

## tl;dr

2 messages between Jun 3, 2009 and Jun 3, 2009. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Shawn O. Pearce· Jun 3, 2009, 17:15 UTC · lore

On a git://host:port/path style URL, if port is not the IANA registered port 9418 for git, the remote git daemon expects us to send "\0host=host:port\0" in the virtual host slot.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../spearce/jgit/transport/TransportGitAnon.java   |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Show changes to org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java +4 −0

diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java
index add7e2a..9edd93e 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java
@@ -103,6 +103,10 @@ void service(final String name, final PacketLineOut pckOut)
 		cmd.append('\0');
 		cmd.append("host=");
 		cmd.append(uri.getHost());
+		if (uri.getPort() != GIT_PORT) {
+			cmd.append(":");
+			cmd.append(uri.getPort());
+		}
 		cmd.append('\0');
 		pckOut.writeString(cmd.toString());
 		pckOut.flush();

-- 
1.6.3.1.333.g3ebba7

Shawn O. Pearce· Jun 3, 2009, 17:19 UTC · re: Shawn O. Pearce · lore

[JGIT PATCH v2] Send non-standard port in host header of git://

On a git://host:port/path style URL, if port is not the IANA registered port 9418 for git, the remote git daemon expects us to send "\0host=host:port\0" in the virtual host slot.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 Arrrgh.  v2 deals with the case when the port isn't in the URL at
 all, its <= 0, in which case its the default port, so we shouldn't
 send it to the server.

 Sorry.  :-)

 .../spearce/jgit/transport/TransportGitAnon.java   |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Show changes to org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java +4 −0

diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java
index add7e2a..0c80b9d 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/TransportGitAnon.java
@@ -103,6 +103,10 @@ void service(final String name, final PacketLineOut pckOut)
 		cmd.append('\0');
 		cmd.append("host=");
 		cmd.append(uri.getHost());
+		if (uri.getPort() > 0 && uri.getPort() != GIT_PORT) {
+			cmd.append(":");
+			cmd.append(uri.getPort());
+		}
 		cmd.append('\0');
 		pckOut.writeString(cmd.toString());
 		pckOut.flush();

-- 
1.6.3.1.333.g3ebba7