threads / discuss / 19649

git-rebase -i not escaping # at the beginning of the line

Subject: git-rebase -i not escaping # at the beginning of the line

## tl;dr

4 messages between Jun 3, 2009 and Jun 3, 2009.

replies: 3people: 3as markdown or json

Petr Baudis· Jun 3, 2009, 10:47 UTC · lore

On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:

Show 7 quoted lines

> Redmine automatically links those log messages to the ticket when we
> use this method.  It works well for git commit -m "#1234 story xyz"
> 
> However, when we use git rebase -i, all of the lines that include the
> # character get stripped out of the commit messages.
> 
> How can we escape these?

This definitely sounds like a bug, what git version are you using?

-- 
				Petr "Pasky" Baudis
The lyf so short, the craft so long to lerne. -- Chaucer

Johannes Schindelin· Jun 3, 2009, 10:53 UTC · re: Petr Baudis · lore

Re: git-rebase -i not escaping # at the beginning of the line

Hi,

On Wed, 3 Jun 2009, Petr Baudis wrote:

Show 10 quoted lines

> On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> > Redmine automatically links those log messages to the ticket when we
> > use this method.  It works well for git commit -m "#1234 story xyz"
> > 
> > However, when we use git rebase -i, all of the lines that include the
> > # character get stripped out of the commit messages.
> > 
> > How can we escape these?
> 
> This definitely sounds like a bug, what git version are you using?

It is sort of a bug, in a very peculiar: try amending such a commit _interactively_. It will not work.

The reason: you are not supposed to start any line in a commit message with a '#'. I would actually have expected "git commit -m" to refuse such a line.

Ciao, Dscho

Petr Baudis· Jun 3, 2009, 10:57 UTC · re: Johannes Schindelin · lore

Re: git-rebase -i not escaping # at the beginning of the line

Hi,

On Wed, Jun 03, 2009 at 12:53:27PM +0200, Johannes Schindelin wrote:

Show 19 quoted lines

> On Wed, 3 Jun 2009, Petr Baudis wrote:
> 
> > On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> > > Redmine automatically links those log messages to the ticket when we
> > > use this method.  It works well for git commit -m "#1234 story xyz"
> > > 
> > > However, when we use git rebase -i, all of the lines that include the
> > > # character get stripped out of the commit messages.
> > > 
> > > How can we escape these?
> > 
> > This definitely sounds like a bug, what git version are you using?
> 
> It is sort of a bug, in a very peculiar: try amending such a commit 
> _interactively_.  It will not work.
> 
> The reason: you are not supposed to start any line in a commit message 
> with a '#'.  I would actually have expected "git commit -m" to refuse such 
> a line.

  the line can also come there during import from another VCS, through
email, or so... I think it's more reasonable to deal with them when
filling in the commit message to the editor than in all the other
places.

-- 
				Petr "Pasky" Baudis
The lyf so short, the craft so long to lerne. -- Chaucer

Alberto Leal· Jun 3, 2009, 11:18 UTC · lore

Re: git-rebase -i not escaping # at the beginning of the line

I`ve been using this and never had any problem.

On Wed, Jun 3, 2009 at 7:47 AM, Petr Baudis <pasky-+ZI9xUNit7I@public.gmane.org> wrote:

Show 18 quoted lines

>
> On Tue, Jun 02, 2009 at 12:28:41PM -0700, donnoman wrote:
> > Redmine automatically links those log messages to the ticket when we
> > use this method.  It works well for git commit -m "#1234 story xyz"
> >
> > However, when we use git rebase -i, all of the lines that include the
> > # character get stripped out of the commit messages.
> >
> > How can we escape these?
>
> This definitely sounds like a bug, what git version are you using?
>
> --
>                                Petr "Pasky" Baudis
> The lyf so short, the craft so long to lerne. -- Chaucer
>
> >
>

--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Git for human beings" group. To post to this group, send email to git-users-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to git-users+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/git-users?hl=en -~----------~----~----~----~------~----~------~--~---