# [PATCH 04/17] http-push: do not SEGV after fetching a bad pack idx file

1 messages from 2009-05-29 to 2009-05-29. Participants: Tay Ray Chuan.
Thread: https://gitlist.dev/t/19583

## Tay Ray Chuan, 2009-05-29 17:58

Subject: [PATCH 04/17] http-push: do not SEGV after fetching a bad pack idx file
Message-ID: <20090530015847.fad3e1f8.rctay89@gmail.com>
URL: https://gitlist.dev/e/20090530015847.fad3e1f8.rctay89%40gmail.com

```
In a70c232 ("http-fetch: do not SEGV after fetching a bad pack idx
file"), changes were made to the setup_index method in http-fetch.c
(known in its present form as http-walker.c after 30ae764 ("Modularize
commit-walker")). Since http-push.c has similar similar code for
processing index files, these changes should apply to http-push.c's
implementation of setup_index as well.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 http-push.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/http-push.c b/http-push.c
index 9655b2c..c48bb73 100644
--- a/http-push.c
+++ b/http-push.c
@@ -1061,6 +1061,8 @@ static int setup_index(unsigned char *sha1)
 		return -1;

 	new_pack = parse_pack_index(sha1);
+	if (!new_pack)
+		return -1; /* parse_pack_index() already issued error message */
 	new_pack->next = repo->packs;
 	repo->packs = new_pack;
 	return 0;
--
1.6.3.1

```