threads / patch / 19582

patch, 17 partshttp*: refactor (v4)

Subject: [PATCH 00/17] http*: refactor (v4)

## tl;dr

One message between May 29, 2009 and May 29, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Tay Ray Chuan· May 29, 2009, 17:58 UTC · lore
Junio: this replaces rc/http-push~10 in pu. I've included your
suggestions and changes.
Mike: I've only taken some of your patches from your WIP patch series
dated Jan 18 (http://kerneltrap.org/mailarchive/git/2009/1/18/4757804).
Here's a list of changes from Mike's patches:
- the contentious http_cleanup has been removed in patch #6 (cleanup).
- a new http_request return state, HTTP_START_FAILED, has been added.
- http_request prints an error message ("Unable to start request") when
  start_active_slot fails.
- a new http API method, http_error, has been added.
- in patch #11 (http_fetch_ref), the error ("Unable to start request")
  is still removed, like Mike did, since http_request already handles 
  it.
- in patch #12 (remote_exists), the patch has been re-titled from
  update_remote_info_refs.
Mike Hommey (7):
  Don't expect verify_pack() callers to set pack_size
  transport.c::get_refs_via_curl(): do not leak refs_url
  http.c: new functions for the http API
  transport.c::get_refs_via_curl(): use the new http API
  http.c::http_fetch_ref(): use the new http API
  http-push.c::remote_exists(): use the new http API
  http-push.c::fetch_symref(): use the new http API
Tay Ray Chuan (10):
  http-push, http-walker: style fixes
  http-walker: verify remote packs
  http*: copy string returned by sha1_to_hex
  http-push: do not SEGV after fetching a bad pack idx file
  http*: move common variables and macros to http.[ch]
  http: create function end_url_with_slash
  http*: add http_get_info_packs
  http: use new http API in fetch_index()
  http*: add helper methods for fetching packs
  http*: add helper methods for fetching objects (loose)
 http-push.c   |  536 ++++++---------------------------------------------
 http-walker.c |  530 ++++++++------------------------------------------
 http.c        |  598 ++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 http.h        |   85 ++++++++
 pack-check.c  |    8 +-
 transport.c   |   33 +--
 6 files changed, 820 insertions(+), 970 deletions(-)
-- 
Cheers,
Ray Chuan

← back to recent threads