threads / patch / 19488

patchHave make fail when $(DOCBOOK2X_TEXI) fails in building gitman.texi

Subject: [PATCH] Have make fail when $(DOCBOOK2X_TEXI) fails in building gitman.texi

## tl;dr

One message between May 24, 2009 and May 24, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Samuel Bronson· May 24, 2009, 22:51 UTC · lore

This is handy for when docbook2x isn't installed. Without this change, we would just build a mostly-empty gitman.texi rather than failing as we should.

Signed-off-by: Samuel Bronson <naesten@gmail.com>
---
 Documentation/Makefile |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Show changes to Documentation/Makefile +4 −2
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 144ec32..2998f0d 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -205,9 +205,11 @@ user-manual.pdf: user-manual.xml
 	mv $@+ $@
 
 gitman.texi: $(MAN_XML) cat-texi.perl
-	$(RM) $@+ $@
+	$(RM) $@++ $@+ $@
 	($(foreach xml,$(MAN_XML),$(DOCBOOK2X_TEXI) --encoding=UTF-8 \
-		--to-stdout $(xml);)) | $(PERL_PATH) cat-texi.perl $@ >$@+
+		--to-stdout $(xml);)) >$@++
+	$(PERL_PATH) cat-texi.perl $@ <$@++ >$@+
+	$(RM) $@++
 	mv $@+ $@
 
 gitman.info: gitman.texi
-- 
1.6.3.1

← back to recent threads