# [PATCH 06/18] Don't expect verify_pack() callers to set pack_size

2 messages from 2009-05-24 to 2009-05-24. Participants: Tay Ray Chuan, Junio C Hamano.
Thread: https://gitlist.dev/t/19474

## Tay Ray Chuan, 2009-05-24 14:19

Subject: [PATCH 06/18] Don't expect verify_pack() callers to set pack_size
Message-ID: <20090524221947.c83d6aba.rctay89@gmail.com>
URL: https://gitlist.dev/e/20090524221947.c83d6aba.rctay89%40gmail.com

```
Since use_pack() will end up populating pack_size if it is not already set,
we can just adapt the code in verify_packfile() such that it doesn't require
pack_size to be set beforehand.

This allows callers not to have to set pack_size themselves, and we can thus
revert changes from 1c23d794 (Don't die in git-http-fetch when fetching packs).

Signed-off-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
---
 pack-check.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/pack-check.c b/pack-check.c
index 90c33b1..166ca70 100644
--- a/pack-check.c
+++ b/pack-check.c
@@ -49,7 +49,7 @@ static int verify_packfile(struct packed_git *p,
 	const unsigned char *index_base = p->index_data;
 	git_SHA_CTX ctx;
 	unsigned char sha1[20], *pack_sig;
-	off_t offset = 0, pack_sig_ofs = p->pack_size - 20;
+	off_t offset = 0, pack_sig_ofs = 0;
 	uint32_t nr_objects, i;
 	int err = 0;
 	struct idx_entry *entries;
@@ -61,14 +61,16 @@ static int verify_packfile(struct packed_git *p,
 	 */

 	git_SHA1_Init(&ctx);
-	while (offset < pack_sig_ofs) {
+	do {
 		unsigned int remaining;
 		unsigned char *in = use_pack(p, w_curs, offset, &remaining);
 		offset += remaining;
+		if (!pack_sig_ofs)
+			pack_sig_ofs = p->pack_size - 20;
 		if (offset > pack_sig_ofs)
 			remaining -= (unsigned int)(offset - pack_sig_ofs);
 		git_SHA1_Update(&ctx, in, remaining);
-	}
+	} while (offset < pack_sig_ofs);
 	git_SHA1_Final(sha1, &ctx);
 	pack_sig = use_pack(p, w_curs, pack_sig_ofs, NULL);
 	if (hashcmp(sha1, pack_sig))
--
1.6.3.1

```

## Junio C Hamano, 2009-05-24 20:43

Subject: Re: [PATCH 06/18] Don't expect verify_pack() callers to set pack_size
Message-ID: <7vzld2teo4.fsf@alter.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vzld2teo4.fsf%40alter.siamese.dyndns.org
In-Reply-To: <20090524221947.c83d6aba.rctay89@gmail.com>

```
Tay Ray Chuan <rctay89@gmail.com> writes:

> Since use_pack() will end up populating pack_size if it is not already set,
> we can just adapt the code in verify_packfile() such that it doesn't require
> pack_size to be set beforehand.
>
> This allows callers not to have to set pack_size themselves, and we can thus
> revert changes from 1c23d794 (Don't die in git-http-fetch when fetching packs).
>
> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>

When you forward somebody else's patch, please be careful not to lose the
attribution, by having

	From: Mike Hommey <mh@glandium.org>
        Date: <<<the original author date from Mike>>>

and an empty line before you start the commit log message.

```