threads / patch / 19458

patcht5500-fetch-pack: ignore output from git init

Subject: [PATCH] t5500-fetch-pack: ignore output from git init

## tl;dr

4 messages between May 23, 2009 and May 24, 2009. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Stephen Boyd· May 23, 2009, 19:34 UTC · lore

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
 t/t5500-fetch-pack.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t5500-fetch-pack.sh +1 −1

diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh
index c450f33..ce74508 100755
--- a/t/t5500-fetch-pack.sh
+++ b/t/t5500-fetch-pack.sh
@@ -97,7 +97,7 @@ pull_to_client () {
 (
 	mkdir client &&
 	cd client &&
-	git init 2>> log2.txt &&
+	git init 2>> log2.txt > /dev/null &&
 	git config transfer.unpacklimit 0
 )

-- 
1.6.3.1.145.gb74d77

Jeff King· May 24, 2009, 16:43 UTC · re: Stephen Boyd · lore

Re: [PATCH] t5500-fetch-pack: ignore output from git init

On Sat, May 23, 2009 at 12:34:42PM -0700, Stephen Boyd wrote:

> Signed-off-by: Stephen Boyd <bebarino@gmail.com>

There is no rationale given in the commit message, but I assume it is "this spews useless crap to the terminal that interferes with the usual test output".

However, this seems like the wrong direction. We already have a nice test infrastructure that redirects test output away from the user and respects "--verbose" to turn it back on. t5500 does quite a bit of work outside the test harness, and it makes more sense to me to move it inside. That would take care of your useless spew, _and_ it would help detect failures in a more robust way.

In other words:

Show 12 quoted lines

> diff --git a/t/t5500-fetch-pack.sh b/t/t5500-fetch-pack.sh
> index c450f33..ce74508 100755
> --- a/t/t5500-fetch-pack.sh
> +++ b/t/t5500-fetch-pack.sh
> @@ -97,7 +97,7 @@ pull_to_client () {
>  (
>  	mkdir client &&
>  	cd client &&
> -	git init 2>> log2.txt &&
> +	git init 2>> log2.txt > /dev/null &&
>  	git config transfer.unpacklimit 0
>  )

Why not:

  test_expect_success 'setup client repo' '
    mkdir client &&
    (cd client &&
     git init 2>>log2.txt &&
     git config transfer.unpacklimit 0
    )
  '

-Peff

Jeff King· May 24, 2009, 16:48 UTC · re: Jeff King · lore

Re: [PATCH] t5500-fetch-pack: ignore output from git init

On Sun, May 24, 2009 at 12:43:30PM -0400, Jeff King wrote:

Show 19 quoted lines

> > +++ b/t/t5500-fetch-pack.sh
> > @@ -97,7 +97,7 @@ pull_to_client () {
> >  (
> >  	mkdir client &&
> >  	cd client &&
> > -	git init 2>> log2.txt &&
> > +	git init 2>> log2.txt > /dev/null &&
> >  	git config transfer.unpacklimit 0
> >  )
> 
> Why not:
> 
>   test_expect_success 'setup client repo' '
>     mkdir client &&
>     (cd client &&
>      git init 2>>log2.txt &&
>      git config transfer.unpacklimit 0
>     )
>   '

Actually, taking a closer look at the script, I think you could probably ditch the '2>>log2.txt' bit entirely. The log file is never read and appears to be completely for debugging. Putting the code into the test harness means that output will respect --verbose properly, which means a separate log is unnecessary.

-Peff

Stephen Boyd· May 24, 2009, 17:43 UTC · re: Jeff King · lore

Re: [PATCH] t5500-fetch-pack: ignore output from git init

Jeff King wrote:

Show 7 quoted lines

> Actually, taking a closer look at the script, I think you could probably
> ditch the '2>>log2.txt' bit entirely. The log file is never read and
> appears to be completely for debugging. Putting the code into the test
> harness means that output will respect --verbose properly, which means a
> separate log is unnecessary.
>
> -Peff

Yeah I sent this off real quick because of the reason you state (terminal crap). In the end, the test really needs to be modernized. If someone else doesn't get around to it, I'll start seeing what I can do to make it better.