threads / patch / 19427

patchgit-send-email: Handle quotes when parsing .mailrc files

Subject: [PATCH] git-send-email: Handle quotes when parsing .mailrc files

## tl;dr

One message between May 21, 2009 and May 21, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Eric W. Biederman· May 21, 2009, 02:45 UTC · lore

It is legal and not uncommon to use quotes in a .mailrc file so you can include a persons fullname as well as their email alias. Handle this by using quotewords instead of split when parsing .mailrc files.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to git-send-email.perl +1 −1
diff --git a/git-send-email.perl b/git-send-email.perl
index cccbf45..e3408d5 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -409,7 +409,7 @@ my %parse_alias = (
 	mailrc => sub { my $fh = shift; while (<$fh>) {
 		if (/^alias\s+(\S+)\s+(.*)$/) {
 			# spaces delimit multiple addresses
-			$aliases{$1} = [ split(/\s+/, $2) ];
+			$aliases{$1} = [ quotewords('\s+', 0, $2) ];
 		}}},
 	pine => sub { my $fh = shift; my $f='\t[^\t]*';
 	        for (my $x = ''; defined($x); $x = $_) {
-- 
1.6.3.1.54.g99dd.dirty

← back to recent threads