# [PATCH] gitk: Handle msysGit version during version comparisons 5 messages from 2009-05-18 to 2009-05-19. Participants: Pat Thoyts, Paul Mackerras, Johannes Schindelin, Michael J Gruber. Thread: https://gitlist.dev/t/19408 ## Pat Thoyts, 2009-05-18 21:46 Subject: [PATCH] gitk: Handle msysGit version during version comparisons Message-ID: <87hbzirso6.fsf@users.sourceforge.net> URL: https://gitlist.dev/e/87hbzirso6.fsf%40users.sourceforge.net ``` msysGit generates version strings with text appended which cannot be used with vcompare. Limit git_version to the first three digits which are the real git version. Signed-off-by: Pat Thoyts --- gitk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitk b/gitk index 0804e6e..1855390 100755 --- a/gitk +++ b/gitk @@ -11152,7 +11152,7 @@ set nullid2 "0000000000000000000000000000000000000001" set nullfile "/dev/null" set have_tk85 [expr {[package vcompare $tk_version "8.5"] >= 0}] -set git_version [lindex [exec git version] end] +set git_version [join [lrange [split [lindex [exec git version] end] .] 0 2] .] set runq {} set history {} -- 1.6.3.msysgit.0 ``` ## Paul Mackerras, 2009-05-18 22:57 Subject: Re: [PATCH] gitk: Handle msysGit version during version comparisons Message-ID: <18961.59382.839207.898823@cargo.ozlabs.ibm.com> URL: https://gitlist.dev/e/18961.59382.839207.898823%40cargo.ozlabs.ibm.com In-Reply-To: <87hbzirso6.fsf@users.sourceforge.net> ``` Pat Thoyts writes: > msysGit generates version strings with text appended which cannot > be used with vcompare. Limit git_version to the first three digits > which are the real git version. Thanks, applied. Paul. ``` ## Johannes Schindelin, 2009-05-19 08:43 Subject: Re: [PATCH] gitk: Handle msysGit version during version comparisons Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0905191043320.26154%40pacific.mpi-cbg.de In-Reply-To: <87hbzirso6.fsf@users.sourceforge.net> ``` Hi, On Mon, 18 May 2009, Pat Thoyts wrote: > > msysGit generates version strings with text appended which cannot > be used with vcompare. Limit git_version to the first three digits > which are the real git version. > > Signed-off-by: Pat Thoyts Is that indent intentional? Ciao, Dscho ``` ## Michael J Gruber, 2009-05-19 08:51 Subject: Re: [PATCH] gitk: Handle msysGit version during version comparisons Message-ID: <4A127306.6040904@drmicha.warpmail.net> URL: https://gitlist.dev/e/4A127306.6040904%40drmicha.warpmail.net In-Reply-To: ``` Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43: > Hi, > > On Mon, 18 May 2009, Pat Thoyts wrote: > >> >> msysGit generates version strings with text appended which cannot >> be used with vcompare. Limit git_version to the first three digits >> which are the real git version. >> >> Signed-off-by: Pat Thoyts > > Is that indent intentional? > > Ciao, > Dscho It is clearly indentional :) [During my git beginnings, the standard output format of git log made me believe I should format commit message bodies like that, too.] Michael ``` ## Pat Thoyts, 2009-05-19 10:38 Subject: Re: [PATCH] gitk: Handle msysGit version during version comparisons Message-ID: <877i0ds7hr.fsf@users.sourceforge.net> URL: https://gitlist.dev/e/877i0ds7hr.fsf%40users.sourceforge.net In-Reply-To: <4A127306.6040904@drmicha.warpmail.net> ``` Michael J Gruber writes: >Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43: >> Hi, >> >> On Mon, 18 May 2009, Pat Thoyts wrote: >> >>> >>> msysGit generates version strings with text appended which cannot >>> be used with vcompare. Limit git_version to the first three digits >>> which are the real git version. >>> >>> Signed-off-by: Pat Thoyts >> >> Is that indent intentional? >> >> Ciao, >> Dscho > >It is clearly indentional :) > >[During my git beginnings, the standard output format of git log made me >believe I should format commit message bodies like that, too.] It was intentional and the above followup is why. Evidently I should not do so in the future. -- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD ```