# [EGIT PATCH 1/1] Micro optimise getting ignored status of a resource 1 messages from 2009-05-03 to 2009-05-03. Participants: Ferry Huberts. Thread: https://gitlist.dev/t/19164 ## Ferry Huberts, 2009-05-03 08:41 Subject: [EGIT PATCH 1/1] Micro optimise getting ignored status of a resource Message-ID: <9850c6445ac62a8ed8c76282b07f8a2cf8064e8f.1241339812.git.ferry.huberts@pelagic.nl> URL: https://gitlist.dev/e/9850c6445ac62a8ed8c76282b07f8a2cf8064e8f.1241339812.git.ferry.huberts%40pelagic.nl ``` Do not evaluate getting the ignored status of a resource twice when once is enough. Signed-off-by: Ferry Huberts --- .../org/spearce/egit/core/op/TrackOperation.java | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/org.spearce.egit.core/src/org/spearce/egit/core/op/TrackOperation.java b/org.spearce.egit.core/src/org/spearce/egit/core/op/TrackOperation.java index 29b4344..5f80698 100644 --- a/org.spearce.egit.core/src/org/spearce/egit/core/op/TrackOperation.java +++ b/org.spearce.egit.core/src/org/spearce/egit/core/op/TrackOperation.java @@ -94,14 +94,15 @@ public boolean visit(IResource resource) throws CoreException { // first. If a resource within a ignored folder is marked // we ignore it here, i.e. there is no way to unmark it expect // by explicitly selecting and invoking track on it. + boolean isIgnored = Team.isIgnoredHint(resource); if (resource.getType() == IResource.FILE) { Entry entry = index.getEntry(repoPath); - if (!Team.isIgnoredHint(resource) || entry != null && entry.isAssumedValid()) { + if (!isIgnored || entry != null && entry.isAssumedValid()) { entry = index.add(rm.getWorkDir(), new File(rm.getWorkDir(), repoPath)); entry.setAssumeValid(false); } } - if (Team.isIgnoredHint(resource)) + if (isIgnored) return false; } catch (IOException e) { -- 1.6.0.6 ```