threads / patch / 19129

patchimprove error message in config.c

Subject: [PATCH] improve error message in config.c

## tl;dr

One message between Apr 29, 2009 and Apr 29, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Alex Riesen· Apr 29, 2009, 21:27 UTC · lore
Show errno if opening a lockfile fails.
Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

I miss them error codes greately. Especially when a problem is hard to reproduce.

 config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to config.c +1 −1
diff --git a/config.c b/config.c
index 1750cfb..8bd953c 100644
--- a/config.c
+++ b/config.c
@@ -996,7 +996,7 @@ int git_config_set_multivar(const char* key, const char* value,
 	lock = xcalloc(sizeof(struct lock_file), 1);
 	fd = hold_lock_file_for_update(lock, config_filename, 0);
 	if (fd < 0) {
-		error("could not lock config file %s", config_filename);
+		error("could not lock config file %s: %s", config_filename, strerror(errno));
 		free(store.key);
 		ret = -1;
 		goto out_free;
-- 
1.6.3.rc3.39.g49fd5

← back to recent threads