threads / patch / 19068

patchprune-packed: advanced progress even for non-existing fan-out directories

Subject: [PATCH] prune-packed: advanced progress even for non-existing fan-out directories

## tl;dr

One message between Apr 27, 2009 and Apr 27, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Johannes Sixt· Apr 27, 2009, 07:44 UTC · lore

A progress indicator is used to count through the 256 object fan-out directories while unused object files are removed. (However, it becomes visible only if this process takes long enough.)

Previously, display_progress() was only called if object files were actually removed. But if directories towards the end (fd/, fe/, ff/) did not exist, this could leave a strange line

   Removing duplicate objects:  99% (255/256), done.
in the terminal instead of the expected "100% (256/256)".
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 builtin-prune-packed.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to builtin-prune-packed.c +1 −0
diff --git a/builtin-prune-packed.c b/builtin-prune-packed.c
index 2d5b2cd..4942892 100644
--- a/builtin-prune-packed.c
+++ b/builtin-prune-packed.c
@@ -55,6 +55,7 @@ void prune_packed_objects(int opts)
 	for (i = 0; i < 256; i++) {
 		DIR *d;
 
+		display_progress(progress, i + 1);
 		sprintf(pathname + len, "%02x/", i);
 		d = opendir(pathname);
 		if (!d)
-- 
1.6.3.rc1.88.g1bf9

← back to recent threads