threads / patch / 19055

patcht9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

Subject: [PATCH] t9001: use older Getopt::Long boolean prefix '--no' rather than '--no-'

## tl;dr

2 messages between Apr 24, 2009 and Apr 24, 2009. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Brandon Casey· Apr 24, 2009, 23:18 UTC · lore

The '--no-thread' option is a Getopt::Long boolean option. The '--no-' prefix (as in --no-thread) for boolean options is not supported in Getopt::Long version 2.32 which was released with Perl 5.8.0. This version only supports '--no' as in '--nothread'. More recent versions of Getopt::Long, such as version 2.34, support either prefix. So use the older form in the tests.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 t/t9001-send-email.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t9001-send-email.sh +1 −1

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index d9420e0..ce26ea4 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -616,7 +616,7 @@ test_expect_success 'in-reply-to but no threading' '
 		--from="Example <nobody@example.com>" \
 		--to=nobody@example.com \
 		--in-reply-to="<in-reply-id@example.com>" \
-		--no-thread \
+		--nothread \
 		$patches |
 	grep "In-Reply-To: <in-reply-id@example.com>"
 '

-- 
1.6.2.4.24.gde59d2

Brandon Casey· Apr 24, 2009, 23:18 UTC · re: Brandon Casey · lore

[PATCH] t7700-repack: repack -a now works properly, expect success from test

Since the recent rework of the object listing mechanism of pack-objects/rev-list, git-repack now properly packs objects from alternate repositories even when the local repository contains packs.

Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 t/t7700-repack.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to t/t7700-repack.sh +1 −1

diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh
index 6b29bff..87c9b0e 100755
--- a/t/t7700-repack.sh
+++ b/t/t7700-repack.sh
@@ -69,7 +69,7 @@ test_expect_success 'packed obs in alt ODB are repacked even when local repo is
 	done
 '
 
-test_expect_failure 'packed obs in alt ODB are repacked when local repo has packs' '
+test_expect_success 'packed obs in alt ODB are repacked when local repo has packs' '
 	rm -f .git/objects/pack/* &&
 	echo new_content >> file1 &&
 	git add file1 &&

-- 
1.6.2.4.24.gde59d2