threads / patch / 19049

patch, 3 partshttp-push: fix fetching

Subject: [PATCH 0/3] http-push: fix fetching

## tl;dr

One message between Apr 24, 2009 and Apr 24, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Tay Ray Chuan· Apr 24, 2009, 16:35 UTC · lore

http-push.c contains a lot of fetching code, but it's not known if it really works, given that most people fetch first before pushing (after all, the git manual recommends this).

The first two patches add tests[1] that demonstrate that http-push.c fails to fetch from the remote repo, and remedy this by ensuring fetch requests are sent out. Along the way, code that sends out requests on the requests queue is refactored (run_request_queue()), and a mechanism against accidental pushing to the remote side is introduced.

Footnotes:
[1] the tests coerce http-push into fetching objects from the repo by
    removing local objects before executing http-push, and represent
    just one possible workflow that lead to fetching in http-push.
Tay Ray Chuan (3):
  t5540-http-push: test fetching of loose objects
  t5540-http-push: test fetching of packed objects
  http-push: send out fetch requests on queue
 http-push.c          |   37 ++++++++++++++++++++++++++-----------
 t/t5540-http-push.sh |   36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 62 insertions(+), 11 deletions(-)
-- 
Cheers,
Ray Chuan

← back to recent threads