threads / patch / 18985

patchbisect-helper: fix grammatical typo in exit_if_skipped_commits()

Subject: [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()

## tl;dr

2 messages between Apr 21, 2009 and Apr 22, 2009. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Stephen Boyd· Apr 21, 2009, 06:31 UTC · lore

Signed-off-by: Stephen Boyd <bebarino@gmail.com>
---
Christian Couder wrote:

Show 12 quoted lines

> Le lundi 20 avril 2009, Stephen Boyd a Ã©crit : 
>> Christian Couder wrote: 
>>> +   printf("There are only 'skip'ped commit left to test.\n" 
>>> +          "The first bad commit could be any of:\n") 
>> Should this be "There are only 'skip'ped commits left to test"? 
> 
> Yes, but the same message was printed previously, so it is a slightly  
> incompatible change and I think it should go into another patch. Would you  
> care to send such a patch? 
> 
> Thanks, 
> Christian.

 
This is against pu.

 bisect.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to bisect.c +1 −1

diff --git a/bisect.c b/bisect.c
index f6e1378..5902e83 100644
--- a/bisect.c
+++ b/bisect.c
@@ -575,7 +575,7 @@ static void exit_if_skipped_commits(struct commit_list *tried,
 	if (!tried)
 		return;
 
-	printf("There are only 'skip'ped commit left to test.\n"
+	printf("There are only 'skip'ped commits left to test.\n"
 	       "The first bad commit could be any of:\n");
 	print_commit_list(tried, "%s\n", "%s\n");
 	if (bad)

-- 
1.6.2.3

Christian Couder· Apr 22, 2009, 05:01 UTC · re: Stephen Boyd · lore

Re: [PATCH] bisect-helper: fix grammatical typo in exit_if_skipped_commits()

Le mardi 21 avril 2009, Stephen Boyd a écrit :

Show 18 quoted lines

> This is against pu.
>
>  bisect.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index f6e1378..5902e83 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -575,7 +575,7 @@ static void exit_if_skipped_commits(struct
> commit_list *tried, if (!tried)
>  		return;
>
> -	printf("There are only 'skip'ped commit left to test.\n"
> +	printf("There are only 'skip'ped commits left to test.\n"
>  	       "The first bad commit could be any of:\n");
>  	print_commit_list(tried, "%s\n", "%s\n");
>  	if (bad)

Acked-by: Christian Couder <chriscool@tuxfamily.org>

Thanks, Christian.