threads / patch / 18801

patchgit-svn: always initialize with core.autocrlf=false

Subject: [PATCH] git-svn: always initialize with core.autocrlf=false

## tl;dr

4 messages between Apr 9, 2009 and Apr 9, 2009. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Johannes Schindelin· Apr 9, 2009, 11:29 UTC · lore

It has been reported time and time again in relation to msysGit that git-svn does not work well when core.autocrlf has any value other than 'false'. So let's make it so by default.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to git-svn.perl +1 −0
diff --git a/git-svn.perl b/git-svn.perl
index 8be6be0..d4e8fc8 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -325,6 +325,7 @@ sub do_git_init_db {
 		command_noisy(@init_db);
 		$_repository = Git->repository(Repository => ".git");
 	}
+	command_noisy('config', 'core.autocrlf', 'false');
 	my $set;
 	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
 	foreach my $i (keys %icv) {

-- 
1.6.2.1.613.g25746
Eric Wong· Apr 9, 2009, 16:59 UTC · re: Johannes Schindelin · lore

Re: [PATCH] git-svn: always initialize with core.autocrlf=false

Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
Show 5 quoted lines
> It has been reported time and time again in relation to msysGit that
> git-svn does not work well when core.autocrlf has any value other than
> 'false'.  So let's make it so by default.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Eric Wong <normalperson@yhbt.net>
Show 18 quoted lines
> ---
>  git-svn.perl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 8be6be0..d4e8fc8 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -325,6 +325,7 @@ sub do_git_init_db {
>  		command_noisy(@init_db);
>  		$_repository = Git->repository(Repository => ".git");
>  	}
> +	command_noisy('config', 'core.autocrlf', 'false');
>  	my $set;
>  	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
>  	foreach my $i (keys %icv) {
> -- 
> 1.6.2.1.613.g25746
-- 
Eric Wong
Ferry Huberts (Pelagic)· Apr 9, 2009, 17:21 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: always initialize with core.autocrlf=false

Eric Wong wrote:
Show 28 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
>> It has been reported time and time again in relation to msysGit that
>> git-svn does not work well when core.autocrlf has any value other than
>> 'false'.  So let's make it so by default.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Acked-by: Eric Wong <normalperson@yhbt.net>
> 
>> ---
>>  git-svn.perl |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 8be6be0..d4e8fc8 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -325,6 +325,7 @@ sub do_git_init_db {
>>  		command_noisy(@init_db);
>>  		$_repository = Git->repository(Repository => ".git");
>>  	}
>> +	command_noisy('config', 'core.autocrlf', 'false');
>>  	my $set;
>>  	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
>>  	foreach my $i (keys %icv) {
>> -- 
>> 1.6.2.1.613.g25746
>

funny that this kind of seems to get through while my suggestion (and proff by tests) to do the same for the cvs-import stuff resulted in hefty discussions and no consensus on what to do, the result of which is to do nothing. i guess i couldn't make myself clear enough?

Johannes Schindelin· Apr 9, 2009, 18:30 UTC · re: Ferry Huberts (Pelagic) · lore

Re: [PATCH] git-svn: always initialize with core.autocrlf=false

Hi,
On Thu, 9 Apr 2009, Ferry Huberts (Pelagic) wrote:
Show 33 quoted lines
> Eric Wong wrote:
> > Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
> >> It has been reported time and time again in relation to msysGit that
> >> git-svn does not work well when core.autocrlf has any value other than
> >> 'false'.  So let's make it so by default.
> >>
> >> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > 
> > Acked-by: Eric Wong <normalperson@yhbt.net>
> > 
> >> ---
> >>  git-svn.perl |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/git-svn.perl b/git-svn.perl
> >> index 8be6be0..d4e8fc8 100755
> >> --- a/git-svn.perl
> >> +++ b/git-svn.perl
> >> @@ -325,6 +325,7 @@ sub do_git_init_db {
> >>  		command_noisy(@init_db);
> >>  		$_repository = Git->repository(Repository => ".git");
> >>  	}
> >> +	command_noisy('config', 'core.autocrlf', 'false');
> >>  	my $set;
> >>  	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
> >>  	foreach my $i (keys %icv) {
> >> -- 
> >> 1.6.2.1.613.g25746
> > 
> funny that this kind of seems to get through while my suggestion (and
> proff by tests) to do the same for the cvs-import stuff resulted in
> hefty discussions and no consensus on what to do, the result of which is
> to do nothing. i guess i couldn't make myself clear enough?

Actually, I was very much in favor of it. Care to resend, for our pleasure, pretty please?

Thanks, Dscho

← back to recent threads