threads / patch / 18761

patch, 3 partsremove static vars from "builtin-rev-list.c"

Subject: [PATCH 0/3] remove static vars from "builtin-rev-list.c"

## tl;dr

One message between Apr 7, 2009 and Apr 7, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Christian Couder· Apr 7, 2009, 04:50 UTC · lore

This patch series removes all static variables from "builtin-rev-list.c" except the usage string.

This cleans up the code and should please Dscho.

It also makes it possible to remove restrictions on using the "sho_bisect_vars" function.

  list-objects: add "void *data" parameter to show functions
  rev-list: remove last static vars used in "show_commit"
  rev-list: add "int bisect_show_flags" in "struct rev_list_info"
 bisect.c               |    8 +++-
 bisect.h               |   18 ++++----
 builtin-pack-objects.c |    6 +-
 builtin-rev-list.c     |  109 ++++++++++++++++++++++++------------------------
 list-objects.c         |    9 ++--
 list-objects.h         |    6 +-
 upload-pack.c          |    6 +-
 7 files changed, 84 insertions(+), 78 deletions(-)
PS: Sorry but it looks like the script I used to send this series has some bugs.
First the date in the email are wrong, and then I have to resend this cover letter
because it did not appear on the mailing list.

← back to recent threads