# [PATCH] git-gui: fix use of undeclared variable diff_empty_count

2 messages from 2009-04-06 to 2009-04-07. Participants: Joerg Bornemann.
Thread: https://gitlist.dev/t/18753

## Joerg Bornemann, 2009-04-06 19:59

Subject: [PATCH] git-gui: fix use of undeclared variable diff_empty_count
Message-ID: <49DA5F20.4030800@web.de>
URL: https://gitlist.dev/e/49DA5F20.4030800%40web.de

```
Commit 584fa9cc introduced the global variable diff_empty_count, which
is used in diff.tcl. This variable wasn't declared anywhere which
resulted in an ugly error message box instead of the intended
informative message.

Signed-off-by: Joerg Bornemann <joerg.bornemann@web.de>
---
  git-gui.sh |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-gui.sh b/git-gui.sh
index e4a9230..46b056f 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1131,6 +1131,7 @@ set current_diff_path {}
  set is_3way_diff 0
  set is_conflict_diff 0
  set selected_commit_type new
+set diff_empty_count 0

  set nullid "0000000000000000000000000000000000000000"
  set nullid2 "0000000000000000000000000000000000000001"
--
1.6.0.2.1172.ga5ed0

```

## Joerg Bornemann, 2009-04-07 08:07

Subject: Re: [PATCH] git-gui: fix use of undeclared variable diff_empty_count
Message-ID: <49DB09A6.1070403@web.de>
URL: https://gitlist.dev/e/49DB09A6.1070403%40web.de
In-Reply-To: <49DA5F20.4030800@web.de>

```
This bug occurs with msysgit under mysterious circumstances. We have at
least two Windows machines where "git diff" works correctly but "git 
gui" is unable to get the actual diffs. Before commit 584fa9cc, git gui 
favoured the user with an infinite message box loop. This is what 
584fa9cc should've fixed: display a nice message to the user. Instead I 
see the Tcl error message box, complaining about the missing variable 
diff_empty_count.

```