threads / patch / 18728

v2mergetool--lib: add new merge tool TortoiseMerge

Subject: [PATCH v2] mergetool--lib: add new merge tool TortoiseMerge

## tl;dr

3 messages between Apr 5, 2009 and Apr 6, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

David Aguilar· Apr 5, 2009, 04:00 UTC · lore

From: Markus Heidelberg <markus.heidelberg@web.de>

TortoiseMerge comes with TortoiseSVN or TortoiseGit for Windows. It can only be used as a merge tool with an existing base file. It cannot be used without a base nor as a diff tool.

The documentation only mentions the slash '/' as command line option prefix, which refused to work, but the parser also accepts the dash '-'

See http://code.google.com/p/msysgit/issues/detail?id=226

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---

This is Markus' patch rebased on top of my latest refactoring patch. It didn't apply cleanly so I figured I'd resolve the merge myself.

 git-mergetool--lib.sh |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)

Show changes to git-mergetool--lib.sh +14 −1

diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
index dcd4516..268485a 100644
--- a/git-mergetool--lib.sh
+++ b/git-mergetool--lib.sh
@@ -46,10 +46,13 @@ check_unchanged () {
 
 valid_tool () {
 	case "$1" in
-	kdiff3 | kompare | tkdiff | xxdiff | meld | opendiff | emerge | vimdiff | gvimdiff | ecmerge | diffuse)
+	kdiff3 | kompare | tkdiff | xxdiff | meld | opendiff | emerge | vimdiff | gvimdiff | ecmerge | diffuse | tortoisemerge)
 		if test "$1" = "kompare" && ! diff_mode; then
 			return 1
 		fi
+		if test "$1" = "tortoisemerge" && ! merge_mode; then
+			return 1
+		fi
 		;; # happy
 	*)
 		if test -z "$(get_merge_tool_cmd "$1")"; then
@@ -220,6 +223,16 @@ run_merge_tool () {
 		fi
 		status=$?
 		;;
+	tortoisemerge)
+		if $base_present; then
+			touch "$BACKUP"
+			"$merge_tool_path" -base:"$BASE" -mine:"$LOCAL" -theirs:"$REMOTE" -merged:"$MERGED"
+			check_unchanged
+		else
+			echo "TortoiseMerge cannot be used without a base" 1>&2
+			status=1
+		fi
+		;;
 	*)
 		if test -n "$merge_tool_cmd"; then
 			if merge_mode &&

-- 
1.6.2.1.469.gdffc1

Brian Gernhardt· Apr 5, 2009, 05:10 UTC · re: David Aguilar · lore

Re: [PATCH v2] mergetool--lib: add new merge tool TortoiseMerge

On Apr 5, 2009, at 12:00 AM, David Aguilar wrote:

Show 21 quoted lines

> diff --git a/git-mergetool--lib.sh b/git-mergetool--lib.sh
> index dcd4516..268485a 100644
> --- a/git-mergetool--lib.sh
> +++ b/git-mergetool--lib.sh
> @@ -46,10 +46,13 @@ check_unchanged () {
>
> valid_tool () {
> 	case "$1" in
> -	kdiff3 | kompare | tkdiff | xxdiff | meld | opendiff | emerge |  
> vimdiff | gvimdiff | ecmerge | diffuse)
> +	kdiff3 | kompare | tkdiff | xxdiff | meld | opendiff | emerge |  
> vimdiff | gvimdiff | ecmerge | diffuse | tortoisemerge)
> 		if test "$1" = "kompare" && ! diff_mode; then
> 			return 1
> 		fi
> +		if test "$1" = "tortoisemerge" && ! merge_mode; then
> +			return 1
> +		fi
> 		;; # happy
> 	*)
> 		if test -z "$(get_merge_tool_cmd "$1")"; then

Why is `case "$1"` being followed by two `if test "$1" =`s? Wouldn't it be simpler to have separate case arms for them? Especially with how long that list is getting...

~~ Brian

David Aguilar· Apr 6, 2009, 09:27 UTC · re: Brian Gernhardt · lore

Re: [PATCH v2] mergetool--lib: add new merge tool TortoiseMerge

On  0, Brian Gernhardt <benji@silverinsanity.com> wrote:

Show 21 quoted lines

>
> On Apr 5, 2009, at 12:00 AM, David Aguilar wrote:
>
>> valid_tool () {
>> 	case "$1" in
>> 	<lots-of-stuff>)
>> 		if test "$1" = "kompare" && ! diff_mode; then
>> 			return 1
>> 		fi
>> +		if test "$1" = "tortoisemerge" && ! merge_mode; then
>> +			return 1
>> +		fi
>> 		;; # happy
>> 	*)
>> 		if test -z "$(get_merge_tool_cmd "$1")"; then
>
> Why is `case "$1"` being followed by two `if test "$1" =`s?
> Wouldn't it be simpler to have separate case arms for them?
> Especially with how long that list is getting...
>
> ~~ Brian

It would. It wasn't until after the rewrite that I remembered this email... oh well [PATCH v2 14/14] it is

-- 
	David