threads / patch / 18400

patch, 5 partsMethod fails to close stream

Subject: [PATCH JGIT 4/5] Method fails to close stream

## tl;dr

One message between Mar 19, 2009 and Mar 19, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Yann Simon· Mar 19, 2009, 09:16 UTC · lore

The stream was only closed in case of an error. Use a finally block instead to ensure that the stream is closed.

Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
 .../src/org/spearce/jgit/lib/Repository.java       |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java +1 −1
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
index 8132e27..cfd92b8 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
@@ -152,7 +152,7 @@ public Repository(final File d) throws IOException {
 				for (String alt=ar.readLine(); alt!=null; alt=ar.readLine()) {
 					readObjectsDirs(FS.resolve(objectsDir, alt), ret);
 				}
-			} catch (Exception e) {
+			} finally {
 				ar.close();
 			}
 		}
-- 
1.6.1.2

← back to recent threads