[PATCH] bisect succeeds but has non zero exit code

Anton Blanchard· Sep 17, 2005, 04:32 UTC · lore

Hi,

I was writing some scripts to automate a bisection search and noticed I could get a non zero exit code when the command succeeded:

# git-bisect start # echo $? 0

# git-bisect good ef4cbee0b0d0f791bb593f99b702410f3c0efce6 # echo $? 1

# git bisect bad 6d36ba629e0ef47a03d3703ee1d38143c25532a8
Bisecting: 13 revisions left to test after this
[1619cca2921f6927f4240e03f413d4165c7002fc] Partially revert "Fix time
going twice as fast problem on ATI Xpress chipsets"
# echo $?
0

It looks like bisect_next_check returns false and we return a non zero exit code. The following patch forces a good exit code in that case.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

--- git-bisect.sh.orig 2005-09-15 17:37:08.000000000 +1000 +++ git-bisect.sh 2005-09-17 14:24:30.000000000 +1000

Show changes to diff +1 −0

@@ -111,6 +111,7 @@
 
 bisect_auto_next() {
 	bisect_next_check && bisect_next
+	true
 }
 
 bisect_next() {

patchbisect succeeds but has non zero exit code