threads / patch / 18379

patch, 3 partsformat-patch --attach/--inline use filename instead of sha1

Subject: [PATCH 0/3] format-patch --attach/--inline use filename instead of sha1

## tl;dr

One message between Mar 18, 2009 and Mar 18, 2009. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Stephen Boyd· Mar 18, 2009, 19:51 UTC · lore

This patch series modifies the behavior of format-patch when used with the --attach or --inline command line settings. Current behavior names the attached or inlined patches with the sha1 of the commit, which isn't very friendly or easy for a human to use when downloading the attachments. This series replaces the sha1 values with the filename used by format-patch when it outputs the patches to files.

I don't know the guidelines to modifying the rev_info struct, so hopefully adding the filename there is not bad.

Stephen Boyd (3):
  format-patch: remove unused total parameter from reopen_stdout()
  format-patch: create patch filename in get_patch_filename()
  format-patch: --attach/inline uses filename instead of sha1
 builtin-log.c                                      |   48 ++++++++++----------
 log-tree.c                                         |    8 ++--
 revision.h                                         |    1 +
 ....format-patch_--attach_--stdout_initial..master |   12 +++---
 ...format-patch_--attach_--stdout_initial..master^ |    8 ++--
 ...ff.format-patch_--attach_--stdout_initial..side |    4 +-
 ...tdout_--subject-prefix=TESTCASE_initial..master |   12 +++---
 ....format-patch_--inline_--stdout_initial..master |   12 +++---
 ...format-patch_--inline_--stdout_initial..master^ |    8 ++--
 ...ormat-patch_--inline_--stdout_initial..master^^ |    4 +-
 ...ff.format-patch_--inline_--stdout_initial..side |    4 +-
 11 files changed, 61 insertions(+), 60 deletions(-)

← back to recent threads