# [PATCH] git config: clarify bool types 3 messages from 2009-03-17 to 2009-05-06. Participants: Felipe Contreras, Junio C Hamano. Thread: https://gitlist.dev/t/18362 ## Felipe Contreras, 2009-03-17 23:13 Subject: [PATCH] git config: clarify bool types Message-ID: <1237331631-29822-1-git-send-email-felipe.contreras@gmail.com> URL: https://gitlist.dev/e/1237331631-29822-1-git-send-email-felipe.contreras%40gmail.com ``` The value is what it is, the --bool and --bool-or-int options don't specify the value type, just how it is interpreted. For example: a value of '1' can be interpreted as 'true'. Signed-off-by: Felipe Contreras --- This applies on top of the 'next' branch. builtin-config.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-config.c b/builtin-config.c index 1a3baa1..c3a0176 100644 --- a/builtin-config.c +++ b/builtin-config.c @@ -66,9 +66,9 @@ static struct option builtin_config_options[] = { OPT_STRING(0, "get-color", &get_color_slot, "slot", "find the color configured: [default]"), OPT_STRING(0, "get-colorbool", &get_colorbool_slot, "slot", "find the color setting: [stdout-is-tty]"), OPT_GROUP("Type"), - OPT_BIT(0, "bool", &types, "value is \"true\" or \"false\"", TYPE_BOOL), + OPT_BIT(0, "bool", &types, "value is intepreted as bool (\"true\" or \"false\")", TYPE_BOOL), OPT_BIT(0, "int", &types, "value is decimal number", TYPE_INT), - OPT_BIT(0, "bool-or-int", &types, "value is --bool or --int", TYPE_BOOL_OR_INT), + OPT_BIT(0, "bool-or-int", &types, "value is interpreted either as bool or int", TYPE_BOOL_OR_INT), OPT_GROUP("Other"), OPT_BOOLEAN('z', "null", &end_null, "terminate values with NUL byte"), OPT_END(), -- 1.6.2.313.g33352 ``` ## Junio C Hamano, 2009-03-18 01:13 Subject: Re: [PATCH] git config: clarify bool types Message-ID: <7vk56nocpg.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk56nocpg.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1237331631-29822-1-git-send-email-felipe.contreras@gmail.com> ``` Felipe Contreras writes: > The value is what it is, the --bool and --bool-or-int options don't > specify the value type, just how it is interpreted. For example: a value > of '1' can be interpreted as 'true'. > > Signed-off-by: Felipe Contreras > --- > > This applies on top of the 'next' branch. > > builtin-config.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/builtin-config.c b/builtin-config.c > index 1a3baa1..c3a0176 100644 > --- a/builtin-config.c > +++ b/builtin-config.c > @@ -66,9 +66,9 @@ static struct option builtin_config_options[] = { > OPT_STRING(0, "get-color", &get_color_slot, "slot", "find the color configured: [default]"), > OPT_STRING(0, "get-colorbool", &get_colorbool_slot, "slot", "find the color setting: [stdout-is-tty]"), > OPT_GROUP("Type"), > - OPT_BIT(0, "bool", &types, "value is \"true\" or \"false\"", TYPE_BOOL), > + OPT_BIT(0, "bool", &types, "value is intepreted as bool (\"true\" or \"false\")", TYPE_BOOL), I'd rater see it say something like: Output the value as boolean (true or false) so that it is consistent with others you can see in the context. E.g. get-color explains it to order the command to "find the color". "Interpret" is fine too. The point is not about the choice of verb but use of imperative mood. ``` ## Felipe Contreras, 2009-05-06 23:07 Subject: Re: [PATCH] git config: clarify bool types Message-ID: <94a0d4530905061607s14c700e5t4b87166772c75622@mail.gmail.com> URL: https://gitlist.dev/e/94a0d4530905061607s14c700e5t4b87166772c75622%40mail.gmail.com In-Reply-To: <7vk56nocpg.fsf@gitster.siamese.dyndns.org> ``` On Wed, Mar 18, 2009 at 4:13 AM, Junio C Hamano wrote: > Felipe Contreras writes: > >> The value is what it is, the --bool and --bool-or-int options don't >> specify the value type, just how it is interpreted. For example: a value >> of '1' can be interpreted as 'true'. >> >> Signed-off-by: Felipe Contreras >> --- >> >> This applies on top of the 'next' branch. >> >>  builtin-config.c |    4 ++-- >>  1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/builtin-config.c b/builtin-config.c >> index 1a3baa1..c3a0176 100644 >> --- a/builtin-config.c >> +++ b/builtin-config.c >> @@ -66,9 +66,9 @@ static struct option builtin_config_options[] = { >>       OPT_STRING(0, "get-color", &get_color_slot, "slot", "find the color configured: [default]"), >>       OPT_STRING(0, "get-colorbool", &get_colorbool_slot, "slot", "find the color setting: [stdout-is-tty]"), >>       OPT_GROUP("Type"), >> -     OPT_BIT(0, "bool", &types, "value is \"true\" or \"false\"", TYPE_BOOL), >> +     OPT_BIT(0, "bool", &types, "value is intepreted as bool (\"true\" or \"false\")", TYPE_BOOL), > > I'd rater see it say something like: > >        Output the value as boolean (true or false) > > so that it is consistent with others you can see in the context. > E.g. get-color explains it to order the command to "find the color". > > "Interpret" is fine too.  The point is not about the choice of verb but > use of imperative mood. -bool is not only used to output values, it's also used to set them, so it's not related to an action, it's an action modifier, so I don't think it must be imperative. I'm going to resend this patch as is. -- Felipe Contreras ```