# Fix "git-rev-list" revision range parsing

1 messages from 2005-09-17 to 2005-09-17. Participants: Linus Torvalds.
Thread: https://gitlist.dev/t/1835

## Linus Torvalds, 2005-09-17 00:53

Subject: Fix "git-rev-list" revision range parsing
Message-ID: <Pine.LNX.4.58.0509161750420.26803@g5.osdl.org>
URL: https://gitlist.dev/e/Pine.LNX.4.58.0509161750420.26803%40g5.osdl.org

```

There were two bugs in there:
 - if the range didn't end up working, we restored the '.' character in 
   the wrong place.
 - an empty end-of-range should be interpreted as HEAD.

See rev-parse.c for the reference implementation of this.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---
diff --git a/rev-list.c b/rev-list.c
--- a/rev-list.c
+++ b/rev-list.c
@@ -561,6 +561,8 @@ int main(int argc, char **argv)
 			struct commit *exclude = NULL;
 			struct commit *include = NULL;
 			*dotdot = 0;
+			if (!*next)
+				next = "HEAD";
 			exclude = get_commit_reference(arg, UNINTERESTING);
 			include = get_commit_reference(next, 0);
 			if (exclude && include) {
@@ -569,7 +571,7 @@ int main(int argc, char **argv)
 				handle_one_commit(include, &list);
 				continue;
 			}
-			*next = '.';
+			*dotdot = '.';
 		}
 		if (*arg == '^') {
 			flags = UNINTERESTING;

```