threads / patch / 18272

patchsend-email: test --no-thread --in-reply-to combination

Subject: [PATCH] send-email: test --no-thread --in-reply-to combination

## tl;dr

2 messages between Mar 11, 2009 and Mar 11, 2009. Diffs are folded; open one to read it.

replies: 1people: 1as markdown or json

Thomas Rast· Mar 11, 2009, 22:37 UTC · lore

Re: What's cooking in git.git (Mar 2009, #03; Wed, 11)

Junio C Hamano wrote:

Show 14 quoted lines

> * tr/gcov (Thu Feb 19 12:13:42 2009 +0100) 8 commits
>  + Test git-patch-id
>  + Test rev-list --parents/--children
>  + Test log --decorate
>  + Test fsck a bit harder
>  + Test log --graph
>  + Test diff --dirstat functionality
>  + Test that diff can read from stdin
>  + Support coverage testing with GCC/gcov
> 
> * tr/maint-1.6.0-send-email-irt (Sun Mar 1 23:45:41 2009 +0100) 1 commit
>  + send-email: respect in-reply-to regardless of threading
> 
> Tests?

I see you got tired of waiting while I was out drowning in work, so: thanks, especially for fixing up the fsck test!

I'll follow up with a test for the latter topic shortly.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

Thomas Rast· Mar 11, 2009, 22:40 UTC · re: Thomas Rast · lore

3e0c4ff (send-email: respect in-reply-to regardless of threading, 2009-03-01) fixed the handling of the In-Reply-To header when both --no-thread and --in-reply-to are in effect. Add a test for it.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
 t/t9001-send-email.sh |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

Show changes to t/t9001-send-email.sh +11 −0

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 08d5b91..a46f747 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -531,4 +531,15 @@ test_expect_success 'feed two files' '
 	test "z$(sed -n -e 2p subjects)" = "zSubject: [PATCH 2/2] add master"
 '
 
+test_expect_success 'in-reply-to but no threading' '
+	git send-email \
+		--dry-run \
+		--from="Example <nobody@example.com>" \
+		--to=nobody@example.com \
+		--in-reply-to="<in-reply-id@example.com>" \
+		--no-thread \
+		$patches |
+	grep "In-Reply-To: <in-reply-id@example.com>"
+'
+
 test_done

-- 
1.6.2.489.g51f6b7