[PATCH JGIT] Fix parsing peeled line in packed-ref

Daniel Cheng (aka SDiZ)· Mar 6, 2009, 16:05 UTC · lore

From: Daniel Cheng (aka SDiZ) <j16sdiz+freenet@sdiz.net>

When doing a WalkTransport with packed-ref, peeled line are not handled correctly. This patch fix the issue.

Signed-off-by: Daniel Cheng (aka SDiZ) <j16sdiz+freenet@gmail.com>
---
 .../jgit/transport/WalkRemoteObjectDatabase.java   |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java +1 −1

diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java
index a4f8961..d8e727b 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/WalkRemoteObjectDatabase.java
@@ -436,7 +436,7 @@ private void readPackedRefsImpl(final Map<String, Ref> avail,
 			if (line.charAt(0) == '^') {
 				if (last == null)
 					throw new TransportException("Peeled line before ref.");
-				final ObjectId id = ObjectId.fromString(line + 1);
+				final ObjectId id = ObjectId.fromString(line.substring(1));
 				last = new Ref(Ref.Storage.PACKED, last.getName(), last
 						.getObjectId(), id, true);
 				avail.put(last.getName(), last);

-- 
1.6.2.rc2

Shawn O. Pearce· Mar 6, 2009, 16:19 UTC · re: Daniel Cheng (aka SDiZ) · lore

Re: [PATCH JGIT] Fix parsing peeled line in packed-ref

"Daniel Cheng (aka SDiZ)" <j16sdiz+freenet@gmail.com> wrote:

Show 6 quoted lines

> From: Daniel Cheng (aka SDiZ) <j16sdiz+freenet@sdiz.net>
> 
> When doing a WalkTransport with packed-ref, peeled
> line are not handled correctly. This patch fix the issue.
> 
> Signed-off-by: Daniel Cheng (aka SDiZ) <j16sdiz+freenet@gmail.com>

Thanks.  Fix pushed.

-- 
Shawn.

patchFix parsing peeled line in packed-ref