Issue 125 in msysgit: gitk crashes when quit while reading (fwd)

Johannes Schindelin· Feb 27, 2009, 23:45 UTC · lore

Hi Paul,

this came in through msysGit's issue tracker, from a guy who is involved in the Tk project.

---------- Forwarded message ----------
Date: Fri, 27 Feb 2009 23:12:11 +0000
From: codesite-noreply@google.com
To: msysgit@googlegroups.com
Subject: [msysGit] Issue 125 in msysgit: gitk crashes when quit while reading

Comment #4 on issue 125 by patthoyts: gitk crashes when quit while reading http://code.google.com/p/msysgit/issues/detail?id=125

The simplest fix for all current versions of Tk is to apply the following patch to gitk which will flush all the geometry events before it begins reading the commit ids. This avoids the crash. A fix has now been applied to Tk 8.5 and HEAD branches to avoid this in the future.

diff --git a/gitk b/gitk
index dc2a439..197bc67 100755
--- a/gitk
+++ b/gitk
@@ -10884,6 +10884,7 @@ makewindow
# wait for the window to become visible
tkwait visibility .
wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
readrefs

if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings