threads / discuss / 17946

git-grep: small suggestion, -w flag

Subject: git-grep: small suggestion, -w flag

## tl;dr

5 messages between Feb 22, 2009 and Feb 22, 2009.

replies: 4people: 3as markdown or json

Ingo Molnar· Feb 22, 2009, 10:34 UTC · lore
Here's a stupid little git-grep suggestion.

I recently transitioned from the use of egrep to git-grep, and i like it very much (it nicely excludes build related files, etc.), but there's one small detail: the lack of the -w flag.

It's equivalent to this pattern:
   git grep '\<tick_length\>'

And it's the most common grep flag i (and i suspect many others) use, in addition to the (already supported) -l flag.

When grepping for symbols in a large repository (such as the Linux kernel) -w is very common and very useful - there's many similar symbols, variants of each other. I use it when seeing a symbol in an oops, etc.

While i realize that git-grep does not want to be a full grep replacement, there's a real usability difference between having to type:

   git grep '\<schedule\>'
   git grep -w schedule

(especially since backslash is a seldom used key during a normal workflow, so accessing it is often a small mental hickup.)

	Ingo
René Scharfe· Feb 22, 2009, 11:15 UTC · re: Ingo Molnar · lore

Re: git-grep: small suggestion, -w flag

Ingo Molnar schrieb:
Show 5 quoted lines
> Here's a stupid little git-grep suggestion.
> 
> I recently transitioned from the use of egrep to git-grep, and i 
> like it very much (it nicely excludes build related files, 
> etc.), but there's one small detail: the lack of the -w flag.

git grep knows this flag since version 1.4.1. Does it do something different from egrep's?

René
Ingo Molnar· Feb 22, 2009, 16:14 UTC · re: René Scharfe · lore

Re: git-grep: small suggestion, -w flag

* René Scharfe <rene.scharfe@lsrfire.ath.cx> wrote:
Show 9 quoted lines
> Ingo Molnar schrieb:
> > Here's a stupid little git-grep suggestion.
> > 
> > I recently transitioned from the use of egrep to git-grep, and i 
> > like it very much (it nicely excludes build related files, 
> > etc.), but there's one small detail: the lack of the -w flag.
> 
> git grep knows this flag since version 1.4.1.  Does it do 
> something different from egrep's?
ah:
 earth4:~/tip> git grep -lw schedule
 usage: git grep <option>* [-e] <pattern> <rev>* [[--] <path>...]
should have been 'git grep -l -w schedule'.
	Ingo
Miklos Vajna· Feb 22, 2009, 17:20 UTC · re: Ingo Molnar · lore

Re: git-grep: small suggestion, -w flag

On Sun, Feb 22, 2009 at 05:14:10PM +0100, Ingo Molnar <mingo@elte.hu> wrote:
Show 5 quoted lines
>  earth4:~/tip> git grep -lw schedule
>  usage: git grep <option>* [-e] <pattern> <rev>* [[--] <path>...]
> 
> 
> should have been 'git grep -l -w schedule'.
Yeah, that's because git-grep does not use parseopt yet.
I'm willing to work on it once mv/parseopt-ls-files is settled down.
Ingo Molnar· Feb 22, 2009, 17:23 UTC · re: Miklos Vajna · lore

Re: git-grep: small suggestion, -w flag

* Miklos Vajna <vmiklos@frugalware.org> wrote:
Show 11 quoted lines
> On Sun, Feb 22, 2009 at 05:14:10PM +0100, Ingo Molnar <mingo@elte.hu> wrote:
> >  earth4:~/tip> git grep -lw schedule
> >  usage: git grep <option>* [-e] <pattern> <rev>* [[--] <path>...]
> > 
> > 
> > should have been 'git grep -l -w schedule'.
> 
> Yeah, that's because git-grep does not use parseopt yet.
> 
> I'm willing to work on it once mv/parseopt-ls-files is settled 
> down.
As long as it's planned eventually i'm a happy camper! No rush.
	Ingo

← back to recent threads