# [PATCH 4/6] Improve error message for git-filter-branch 5 messages from 2009-02-19 to 2009-02-19. Participants: John Tapsell, Sverre Rabbelier, Johannes Schindelin. Thread: https://gitlist.dev/t/17892 ## John Tapsell, 2009-02-19 07:36 Subject: [PATCH 4/6] Improve error message for git-filter-branch Message-ID: <200902190736.35364.johnflux@gmail.com> URL: https://gitlist.dev/e/200902190736.35364.johnflux%40gmail.com ``` Tell the user that a backup (original) already exists, and how to solve this problem (with -f option) --- git-filter-branch.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/git-filter-branch.sh b/git-filter-branch.sh index 27b57b8..1ca45e2 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -226,7 +226,8 @@ while read sha1 type name do case "$force,$name" in ,$orig_namespace*) - die "Namespace $orig_namespace not empty" + die "Cannot backup - a previous backup already exists in $orig_namespace\n" \ + "Force overwriting the backup with -f" ;; t,$orig_namespace*) git update-ref -d "$name" $sha1 -- 1.6.2.rc1.3.g7d31b.dirty ``` ## Sverre Rabbelier, 2009-02-19 08:44 Subject: Re: [PATCH 4/6] Improve error message for git-filter-branch Message-ID: URL: https://gitlist.dev/e/bd6139dc0902190044x623a9159p473278374df31c8d%40mail.gmail.com In-Reply-To: <200902190736.35364.johnflux@gmail.com> ``` Heya, On Thu, Feb 19, 2009 at 08:36, John Tapsell wrote: > Tell the user that a backup (original) already exists, and how to solve > this problem (with -f option) Very helpful, I like it :)! Although perhaps s/Cannot backup/Cannot create a new backup/ ? -- Cheers, Sverre Rabbelier ``` ## John Tapsell, 2009-02-19 14:19 Subject: Re: [PATCH 4/6] Improve error message for git-filter-branch Message-ID: <43d8ce650902190619u149b4619k3f9e08bc1e5869f8@mail.gmail.com> URL: https://gitlist.dev/e/43d8ce650902190619u149b4619k3f9e08bc1e5869f8%40mail.gmail.com In-Reply-To: <200902190736.35364.johnflux@gmail.com> ``` 2009/2/19 John Tapsell : > Tell the user that a backup (original) already exists, and how to solve > this problem (with -f option) "Oh, and also all are: Signed-off-by: John Tapsell " > --- > git-filter-branch.sh | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/git-filter-branch.sh b/git-filter-branch.sh > index 27b57b8..1ca45e2 100755 > --- a/git-filter-branch.sh > +++ b/git-filter-branch.sh > @@ -226,7 +226,8 @@ while read sha1 type name > do > case "$force,$name" in > ,$orig_namespace*) > - die "Namespace $orig_namespace not empty" > + die "Cannot backup - a previous backup already exists in $orig_namespace\n" \ > + "Force overwriting the backup with -f" > ;; > t,$orig_namespace*) > git update-ref -d "$name" $sha1 > -- > 1.6.2.rc1.3.g7d31b.dirty > > > ``` ## Johannes Schindelin, 2009-02-19 15:03 Subject: Re: [PATCH 4/6] Improve error message for git-filter-branch Message-ID: URL: https://gitlist.dev/e/alpine.DEB.1.00.0902191602520.6223%40intel-tinevez-2-302 In-Reply-To: <43d8ce650902190619u149b4619k3f9e08bc1e5869f8@mail.gmail.com> ``` Hi, On Thu, 19 Feb 2009, John Tapsell wrote: > 2009/2/19 John Tapsell : > > Tell the user that a backup (original) already exists, and how to solve > > this problem (with -f option) > > > "Oh, and also all are: > Signed-off-by: John Tapsell " Might be nice to resend it so that the maintainer has less work, no? Also might be nice to cut the complete crap after the only piece of information in your mail: > > > --- > > git-filter-branch.sh | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/git-filter-branch.sh b/git-filter-branch.sh > > index 27b57b8..1ca45e2 100755 > > --- a/git-filter-branch.sh > > +++ b/git-filter-branch.sh > > @@ -226,7 +226,8 @@ while read sha1 type name > > do > > case "$force,$name" in > > ,$orig_namespace*) > > - die "Namespace $orig_namespace not empty" > > + die "Cannot backup - a previous backup already exists in $orig_namespace\n" \ > > + "Force overwriting the backup with -f" > > ;; > > t,$orig_namespace*) > > git update-ref -d "$name" $sha1 > > -- > > 1.6.2.rc1.3.g7d31b.dirty > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ``` ## Sverre Rabbelier, 2009-02-19 15:13 Subject: Re: [PATCH 4/6] Improve error message for git-filter-branch Message-ID: URL: https://gitlist.dev/e/bd6139dc0902190713o50593c5emaa6934f9efda0e1e%40mail.gmail.com In-Reply-To: ``` On Thu, Feb 19, 2009 at 16:03, Johannes Schindelin wrote: > Might be nice to resend it so that the maintainer has less work, no? Junio said it was ok to ask him to forge and fixup if desired in the other thread. > Also might be nice to cut the complete crap after the only piece of > information in your mail: Somehow you failed to do so yourself ;). -- Cheers, Sverre Rabbelier ```