threads / patch / 17854

patch, 2 partsModify description file to say what this file is

Subject: [PATCH 1/2] Modify description file to say what this file is

## tl;dr

3 messages between Feb 17, 2009 and Feb 17, 2009. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

John Tapsell· Feb 17, 2009, 10:44 UTC · lore

A lot of people see this message for the first time on the gitweb interface, where there is no clue as to what 'this file' means.

Signed-off-by: John Tapsell <johnflux@gmail.com>
---
 templates/hooks--update.sample |    5 +++--
 templates/this--description    |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

Show changes to 2 files +4 −3

templates/hooks--update.sample, templates/this--description

diff --git a/templates/hooks--update.sample b/templates/hooks--update.sample
index 93c6055..f753d28 100755
--- a/templates/hooks--update.sample
+++ b/templates/hooks--update.sample
@@ -43,10 +43,11 @@ allowdeletetag=$(git config --bool hooks.allowdeletetag)
 
 # check for no description
 projectdesc=$(sed -e '1q' "$GIT_DIR/description")
-if [ -z "$projectdesc" -o "$projectdesc" = "Unnamed repository; edit this file to name it for gitweb." ]; then
+case $projectdesc in "Unnamed repository;"*|'')
 	echo "*** Project description file hasn't been set" >&2
 	exit 1
-fi
+	;;
+esac
 
 # --- Check types
 # if $newrev is 0000...0000, it's a commit to delete a ref.
diff --git a/templates/this--description b/templates/this--description
index c6f25e8..914a64e 100644
--- a/templates/this--description
+++ b/templates/this--description
@@ -1 +1 @@
-Unnamed repository; edit this file to name it for gitweb.
+Unnamed repository; edit the .git/description file to name it for gitweb.

-- 
1.6.2.rc1

Sverre Rabbelier· Feb 17, 2009, 11:37 UTC · re: John Tapsell · lore

Re: [PATCH 1/2] Modify description file to say what this file is

Heya,

On Tue, Feb 17, 2009 at 11:44, John Tapsell <johnflux@gmail.com> wrote:

> A lot of people see this message for the first time on the gitweb
> interface, where there is no clue as to what 'this file' means.

It seems you somehow managed to send the exact same message 4 times, what gives?

-- 
Cheers,

Sverre Rabbelier

John Tapsell· Feb 17, 2009, 11:59 UTC · re: Sverre Rabbelier · lore

Re: [PATCH 1/2] Modify description file to say what this file is

2009/2/17 Sverre Rabbelier <srabbelier@gmail.com>:

Show 7 quoted lines

> Heya,
>
> On Tue, Feb 17, 2009 at 11:44, John Tapsell <johnflux@gmail.com> wrote:
>> A lot of people see this message for the first time on the gitweb
>> interface, where there is no clue as to what 'this file' means.
>
> It seems you somehow managed to send the exact same message 4 times, what gives?

I'm really sorry. Gmail kept mangling it, then my email client said it wasn't sending.. bah. I've got it sorted it out now.

John

Show 6 quoted lines

>
> --
> Cheers,
>
> Sverre Rabbelier
>