threads / announce / 17838

[ANNOUNCE] Gerrit Code Review 2.0.3

Subject: [ANNOUNCE] Gerrit Code Review 2.0.3

## tl;dr

11 messages between Feb 17, 2009 and Feb 18, 2009.

replies: 10people: 7as markdown or json

Shawn O. Pearce· Feb 17, 2009, 01:12 UTC · lore

Gerrit is a web based code review system, facilitating online code reviews for projects using the Git version control system.

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer. This functionality enables a more centralized usage of Git.

Gerrit 2.x and later run in any standard Java servlet container, and includes an embedded SSH daemon, providing gitosis like group security and data access. If desired, the review process can be skipped by directly pushing branches/tags, if the necessary access has been granted to the user.

The last time I announced Gerrit on this list, it only ran on Google App Engine. Gerrit 2.x and later is designed to run in any environment, without requiring the use of a Google product, or network connectivity to the Internet. This makes it much more suited for corporate deployments, or open source projects which already have their own servers.

Currently, Gerrit is under very active development, with stable releases being made about once per week. As such, I won't be announcing future releases here very often.

For more information:
  Homepage:   http://code.google.com/p/gerrit/
  Live Demo:  http://review.source.android.com/open
  Source:     git://android.git.kernel.org/tools/gerrit.git
              (but see http://code.google.com/p/gerrit/wiki/Source?tm=4)
-- 
Shawn.
Frank Li· Feb 17, 2009, 07:11 UTC · re: Shawn O. Pearce · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

when I click http://review.source.android.com/open , A Gerrit file download by IE

2009/2/17 Shawn O. Pearce <spearce@spearce.org>:
Show 43 quoted lines
> Gerrit is a web based code review system, facilitating online code
> reviews for projects using the Git version control system.
>
> Gerrit makes reviews easier by showing changes in a side-by-side
> display, and allowing inline comments to be added by any reviewer.
>
> Gerrit simplifies Git based project maintainership by permitting
> any authorized user to submit changes to the master Git repository,
> rather than requiring all approved changes to be merged in by
> hand by the project maintainer.  This functionality enables a more
> centralized usage of Git.
>
> Gerrit 2.x and later run in any standard Java servlet container,
> and includes an embedded SSH daemon, providing gitosis like group
> security and data access.  If desired, the review process can be
> skipped by directly pushing branches/tags, if the necessary access
> has been granted to the user.
>
> The last time I announced Gerrit on this list, it only ran on
> Google App Engine.  Gerrit 2.x and later is designed to run in
> any environment, without requiring the use of a Google product,
> or network connectivity to the Internet.  This makes it much more
> suited for corporate deployments, or open source projects which
> already have their own servers.
>
> Currently, Gerrit is under very active development, with stable
> releases being made about once per week.  As such, I won't be
> announcing future releases here very often.
>
> For more information:
>
>  Homepage:   http://code.google.com/p/gerrit/
>  Live Demo:  http://review.source.android.com/open
>  Source:     git://android.git.kernel.org/tools/gerrit.git
>              (but see http://code.google.com/p/gerrit/wiki/Source?tm=4)
>
> --
> Shawn.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Shawn O. Pearce· Feb 17, 2009, 15:18 UTC · re: Frank Li · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

Frank Li <lznuaa@gmail.com> wrote:
> when I click http://review.source.android.com/open , A Gerrit file
> download by IE
Likely it is this open bug:
  http://jira.source.android.com/jira/browse/GERRIT-62

Gerrit is known to not work in Internet Explorer. As an open source developer, my primary desktop system runs Linux. My portable laptops all run Mac OS X, because its shiny. I have no system capable of running Internet Explorer, nor do I desire to send dollars towards Redmond in order to obtain an OS license in order to do so.

Something is busted in the IE AJAX code used by Gerrit Code Review. I'm guessing that instead of making the data available to the AJAX callback, IE wants to save it as a file on disk. No clue why. And due to the lack of IE, I am unable to debug the problem myself. I am waiting for someone who really cares about using IE to debug it and contribute the patch back.

FWIW, there are open source browsers available even for Microsoft
Windows.  Firefox and Chrome come to mind...  both work, as their
underlying engines are ported to more OSes and are easier to test.
Firefox is currently better tested however.
Show 5 quoted lines
> 2009/2/17 Shawn O. Pearce <spearce@spearce.org>:
> > Gerrit is a web based code review system, facilitating online code
> > reviews for projects using the Git version control system.
> > 
> >  Live Demo:  http://review.source.android.com/open
-- 
Shawn.
Jacob Helwig· Feb 17, 2009, 16:13 UTC · re: Shawn O. Pearce · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

On Tue, Feb 17, 2009 at 07:18, Shawn O. Pearce <spearce@spearce.org> wrote:
Show 13 quoted lines
> Gerrit is known to not work in Internet Explorer.  As an open source
> developer, my primary desktop system runs Linux.  My portable laptops
> all run Mac OS X, because its shiny.  I have no system capable of
> running Internet Explorer, nor do I desire to send dollars towards
> Redmond in order to obtain an OS license in order to do so.
>
> Something is busted in the IE AJAX code used by Gerrit Code Review.
> I'm guessing that instead of making the data available to the AJAX
> callback, IE wants to save it as a file on disk.  No clue why.
> And due to the lack of IE, I am unable to debug the problem myself.
> I am waiting for someone who really cares about using IE to debug
> it and contribute the patch back.
>
I've found IEs4Linux helpful for debugging IE-only issues under Linux.
http://www.tatanka.com.br/ies4linux/page/Main_Page

I don't recall, off hand, if it'll provide IE 7 (and the site isn't working for me right now, so I can't confirm this). It does provide IE 5.0, 5.5, and 6.0, however.

-Jacob
Johannes Schindelin· Feb 17, 2009, 16:44 UTC · re: Jacob Helwig · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

Hi,
On Tue, 17 Feb 2009, Jacob Helwig wrote:
Show 22 quoted lines
> On Tue, Feb 17, 2009 at 07:18, Shawn O. Pearce <spearce@spearce.org> wrote:
> > Gerrit is known to not work in Internet Explorer.  As an open source
> > developer, my primary desktop system runs Linux.  My portable laptops
> > all run Mac OS X, because its shiny.  I have no system capable of
> > running Internet Explorer, nor do I desire to send dollars towards
> > Redmond in order to obtain an OS license in order to do so.
> >
> > Something is busted in the IE AJAX code used by Gerrit Code Review.
> > I'm guessing that instead of making the data available to the AJAX
> > callback, IE wants to save it as a file on disk.  No clue why.
> > And due to the lack of IE, I am unable to debug the problem myself.
> > I am waiting for someone who really cares about using IE to debug
> > it and contribute the patch back.
> >
> 
> I've found IEs4Linux helpful for debugging IE-only issues under Linux.
> 
> http://www.tatanka.com.br/ies4linux/page/Main_Page
> 
> I don't recall, off hand, if it'll provide IE 7 (and the site isn't
> working for me right now, so I can't confirm this).  It does provide
> IE 5.0, 5.5, and 6.0, however.

If I understand Shawn (and the motto "scratch your own itch") correctly, Shawn was not so much interested in being pointed to a way of running IE himself, but more in people who absolutely want to run IE themselves to go and fix the issues.

Ciao, Dscho

Shawn O. Pearce· Feb 17, 2009, 17:09 UTC · re: Johannes Schindelin · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 17 quoted lines
> On Tue, 17 Feb 2009, Jacob Helwig wrote:
> > On Tue, Feb 17, 2009 at 07:18, Shawn O. Pearce <spearce@spearce.org> wrote:
> > >
> > > Something is busted in the IE AJAX code used by Gerrit Code Review.
> > 
> > I've found IEs4Linux helpful for debugging IE-only issues under Linux.
> > 
> > http://www.tatanka.com.br/ies4linux/page/Main_Page
> > 
> > I don't recall, off hand, if it'll provide IE 7 (and the site isn't
> > working for me right now, so I can't confirm this).  It does provide
> > IE 5.0, 5.5, and 6.0, however.
> 
> If I understand Shawn (and the motto "scratch your own itch") correctly, 
> Shawn was not so much interested in being pointed to a way of running IE 
> himself, but more in people who absolutely want to run IE themselves to go 
> and fix the issues.
Indeed.

There are probably also license issues with running IE under Linux. IIRC Microsoft only licenses IE for use under Windows itself, and with a valid Windows OS license. As a professional developer, I do actually try to respect the license under which software is delivered to me, even if I have no respect for the vendor... ;-)

-- 
Shawn.
Jacob Helwig· Feb 17, 2009, 21:06 UTC · re: Johannes Schindelin · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

On Tue, Feb 17, 2009 at 08:44, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 36 quoted lines
> Hi,
>
> On Tue, 17 Feb 2009, Jacob Helwig wrote:
>
>> On Tue, Feb 17, 2009 at 07:18, Shawn O. Pearce <spearce@spearce.org> wrote:
>> > Gerrit is known to not work in Internet Explorer.  As an open source
>> > developer, my primary desktop system runs Linux.  My portable laptops
>> > all run Mac OS X, because its shiny.  I have no system capable of
>> > running Internet Explorer, nor do I desire to send dollars towards
>> > Redmond in order to obtain an OS license in order to do so.
>> >
>> > Something is busted in the IE AJAX code used by Gerrit Code Review.
>> > I'm guessing that instead of making the data available to the AJAX
>> > callback, IE wants to save it as a file on disk.  No clue why.
>> > And due to the lack of IE, I am unable to debug the problem myself.
>> > I am waiting for someone who really cares about using IE to debug
>> > it and contribute the patch back.
>> >
>>
>> I've found IEs4Linux helpful for debugging IE-only issues under Linux.
>>
>> http://www.tatanka.com.br/ies4linux/page/Main_Page
>>
>> I don't recall, off hand, if it'll provide IE 7 (and the site isn't
>> working for me right now, so I can't confirm this).  It does provide
>> IE 5.0, 5.5, and 6.0, however.
>
> If I understand Shawn (and the motto "scratch your own itch") correctly,
> Shawn was not so much interested in being pointed to a way of running IE
> himself, but more in people who absolutely want to run IE themselves to go
> and fix the issues.
>
> Ciao,
> Dscho
>
>

Oh, I understand "scratch your own itch", but there's also a difference between unable to, and unwilling to. ;-) I wouldn't have questioned it, or said anything, if it was simply put as: "Known issue, but we don't use IE, so it's not a priority for us. Patches welcome."

(Note: I'm not saying that Shawn should be willing to, just that he's not "unable" to. I also don't claim to know the full nuances of any possible licensing issues.)

thestar@fussycoder.id.au· Feb 18, 2009, 00:13 UTC · re: Jacob Helwig · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

Quoting Jacob Helwig <jacob.helwig@gmail.com>:
Show 5 quoted lines
> On Tue, Feb 17, 2009 at 08:44, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> Hi,
>>
>> On Tue, 17 Feb 2009, Jacob Helwig wrote:
<snip>
Show 28 quoted lines
>>>
>>> I've found IEs4Linux helpful for debugging IE-only issues under Linux.
>>>
>>> http://www.tatanka.com.br/ies4linux/page/Main_Page
>>>
>>> I don't recall, off hand, if it'll provide IE 7 (and the site isn't
>>> working for me right now, so I can't confirm this).  It does provide
>>> IE 5.0, 5.5, and 6.0, however.
>>
>> If I understand Shawn (and the motto "scratch your own itch") correctly,
>> Shawn was not so much interested in being pointed to a way of running IE
>> himself, but more in people who absolutely want to run IE themselves to go
>> and fix the issues.
>>
>> Ciao,
>> Dscho
>>
>>
>
> Oh, I understand "scratch your own itch", but there's also a
> difference between unable to, and unwilling to. ;-)  I wouldn't have
> questioned it, or said anything, if it was simply put as: "Known
> issue, but we don't use IE, so it's not a priority for us.  Patches
> welcome."
>
> (Note: I'm not saying that Shawn should be willing to, just that he's
> not "unable" to. I also don't claim to know the full nuances of any
> possible licensing issues.)

I would've thought that impossible license situations would result in one being unable to use it.

Boyd Lynn Gerber· Feb 17, 2009, 18:53 UTC · re: Jacob Helwig · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

On Tue, 17 Feb 2009, Jacob Helwig wrote:
Show 22 quoted lines
> On Tue, Feb 17, 2009 at 07:18, Shawn O. Pearce <spearce@spearce.org> wrote:
>> Gerrit is known to not work in Internet Explorer.  As an open source
>> developer, my primary desktop system runs Linux.  My portable laptops
>> all run Mac OS X, because its shiny.  I have no system capable of
>> running Internet Explorer, nor do I desire to send dollars towards
>> Redmond in order to obtain an OS license in order to do so.
>>
>> Something is busted in the IE AJAX code used by Gerrit Code Review.
>> I'm guessing that instead of making the data available to the AJAX
>> callback, IE wants to save it as a file on disk.  No clue why.
>> And due to the lack of IE, I am unable to debug the problem myself.
>> I am waiting for someone who really cares about using IE to debug
>> it and contribute the patch back.
>>
>
> I've found IEs4Linux helpful for debugging IE-only issues under Linux.
>
> http://www.tatanka.com.br/ies4linux/page/Main_Page
>
> I don't recall, off hand, if it'll provide IE 7 (and the site isn't
> working for me right now, so I can't confirm this).  It does provide
> IE 5.0, 5.5, and 6.0, however.

You can get IE 7 if you go to the advanced option and choose it. They say it is experimental. I find it works well for when I have to test IE. I only test IE 6 and IE 7 to make sure web pages work in them as well.

-- 
Boyd Gerber <gerberb@zenez.com> 801 849-0213
ZENEZ	1042 East Fort Union #135, Midvale Utah  84047
Gerrit Pape· Feb 17, 2009, 09:01 UTC · re: Shawn O. Pearce · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

On Mon, Feb 16, 2009 at 05:12:56PM -0800, Shawn O. Pearce wrote:
> Gerrit is a web based code review system, facilitating online code
> Gerrit makes reviews easier by showing changes in a side-by-side
> Gerrit simplifies Git based project maintainership by permitting
> Gerrit 2.x and later run in any standard Java servlet container,
> Currently, Gerrit is under very active development, with stable
Somehow this scares me.
Regards, Gerrit.
Shawn O. Pearce· Feb 17, 2009, 15:13 UTC · re: Gerrit Pape · lore

Re: [ANNOUNCE] Gerrit Code Review 2.0.3

Gerrit Pape <pape@smarden.org> wrote:
Show 9 quoted lines
> On Mon, Feb 16, 2009 at 05:12:56PM -0800, Shawn O. Pearce wrote:
> > Gerrit is a web based code review system, facilitating online code
> > Gerrit makes reviews easier by showing changes in a side-by-side
> > Gerrit simplifies Git based project maintainership by permitting
> > Gerrit 2.x and later run in any standard Java servlet container,
> 
> > Currently, Gerrit is under very active development, with stable
> 
> Somehow this scares me.
Me too.  :)
http://code.google.com/p/gerrit/wiki/Background

explains some of Gerrit Code Review's lineage. It goes back to a fork of Rietveld, which was named after the Dutch architect Gerrit Rietveld. Because we forked so far away from Rietveld, we renamed it to Gerrit...

-- 
Shawn.

← back to recent threads