# [PATCH] builtin-receive-pack.c: fix compiler warnings about format string 2 messages from 2009-02-15 to 2009-02-15. Participants: René Scharfe, Junio C Hamano. Thread: https://gitlist.dev/t/17804 ## René Scharfe, 2009-02-15 18:18 Subject: [PATCH] builtin-receive-pack.c: fix compiler warnings about format string Message-ID: <1234721938.17613.21.camel@ubuntu.ubuntu-domain> URL: https://gitlist.dev/e/1234721938.17613.21.camel%40ubuntu.ubuntu-domain ``` While all of the strings passed to warning() are, in fact, literals, the compiler doesn't recognize them as such because it doesn't see through the loop used to iterate over them: builtin-receive-pack.c: In function 'warn_unconfigured_deny': builtin-receive-pack.c:247: warning: format not a string literal and no format arguments builtin-receive-pack.c: In function 'warn_unconfigured_deny_delete_current': builtin-receive-pack.c:273: warning: format not a string literal and no format arguments Calm the compiler by adding easily recognizable format string literals. Signed-off-by: Rene Scharfe --- builtin-receive-pack.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-receive-pack.c b/builtin-receive-pack.c index f7e04c4..849f1fe 100644 --- a/builtin-receive-pack.c +++ b/builtin-receive-pack.c @@ -244,7 +244,7 @@ static void warn_unconfigured_deny(void) { int i; for (i = 0; i < ARRAY_SIZE(warn_unconfigured_deny_msg); i++) - warning(warn_unconfigured_deny_msg[i]); + warning("%s", warn_unconfigured_deny_msg[i]); } static char *warn_unconfigured_deny_delete_current_msg[] = { @@ -270,7 +270,7 @@ static void warn_unconfigured_deny_delete_current(void) for (i = 0; i < ARRAY_SIZE(warn_unconfigured_deny_delete_current_msg); i++) - warning(warn_unconfigured_deny_delete_current_msg[i]); + warning("%s", warn_unconfigured_deny_delete_current_msg[i]); } static const char *update(struct command *cmd) ``` ## Junio C Hamano, 2009-02-15 19:34 Subject: Re: [PATCH] builtin-receive-pack.c: fix compiler warnings about format string Message-ID: <7v3aeflck4.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7v3aeflck4.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1234721938.17613.21.camel@ubuntu.ubuntu-domain> ``` Thanks. ```