# [PATCH] git-svn: Fix for rewriteRoot URL containing username.

2 messages from 2009-02-11 to 2009-02-16. Participants: Dévai Tamás, Eric Wong.
Thread: https://gitlist.dev/t/17733

## Dévai Tamás, 2009-02-11 23:14

Subject: [PATCH] git-svn: Fix for rewriteRoot URL containing username.
Message-ID: <1234394042-11577-1-git-send-email-devait@mailbox.sk>
URL: https://gitlist.dev/e/1234394042-11577-1-git-send-email-devait%40mailbox.sk

```
If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option
(or by the --rewrite-root option to 'git svn init') contains a username
(such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find
the repository URL, because the URL contained in the commit message does have
the username removed.

Signed-off-by: Dévai Tamás <devait@mailbox.sk>
---
 git-svn.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 001a1d8..83cb36f 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional
 			my $prefix = '';
 			if ($rwr) {
 				$z = $rwr;
+				remove_username($z);
 			} elsif (defined $svm) {
 				$z = $svm->{source};
 				$prefix = $svm->{replace};
-- 
1.6.1.2

```

## Eric Wong, 2009-02-16 00:55

Subject: Re: [PATCH] git-svn: Fix for rewriteRoot URL containing username.
Message-ID: <20090216005525.GA20625@untitled>
URL: https://gitlist.dev/e/20090216005525.GA20625%40untitled
In-Reply-To: <1234394042-11577-1-git-send-email-devait@mailbox.sk>

```
Dévai Tamás <devait@mailbox.sk> wrote:
> If the new svn root URL given with the svn-remote.<repo>.rewriteRoot config option
> (or by the --rewrite-root option to 'git svn init') contains a username
> (such as 'svn+ssh://username@example.com/repo'), find_by_url() cannot find
> the repository URL, because the URL contained in the commit message does have
> the username removed.
> 
> Signed-off-by: Dévai Tamás <devait@mailbox.sk>

Thanks Dévai,

Acked-by: Eric Wong <normalperson@yhbt.net>

> ---
>  git-svn.perl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 001a1d8..83cb36f 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1693,6 +1693,7 @@ sub find_by_url { # repos_root and, path are optional
>  			my $prefix = '';
>  			if ($rwr) {
>  				$z = $rwr;
> +				remove_username($z);
>  			} elsif (defined $svm) {
>  				$z = $svm->{source};
>  				$prefix = $svm->{replace};
> -- 
> 1.6.1.2

```