# [PATCH] git-rebase-interactive: you can also add new commits to the "work list"

4 messages from 2009-02-09 to 2009-02-09. Participants: Kjetil Barvik, Johannes Schindelin.
Thread: https://gitlist.dev/t/17679

## Kjetil Barvik, 2009-02-09 21:25

Subject: [PATCH] git-rebase-interactive: you can also add new commits to the "work list"
Message-ID: <1234214701-20245-1-git-send-email-barvik@broadpark.no>
URL: https://gitlist.dev/e/1234214701-20245-1-git-send-email-barvik%40broadpark.no

```
Add 2 small lines to document that you can also use 'git rebase
--interactive' to add new commits to the rebased patch-series.  This
is sort of running multiple 'git cherry-pick' commands in one go.

Signed-off-by: Kjetil Barvik <barvik@broadpark.no>
---

  If this is a good idea, soneone should correct my poor english.

  -- kjetil


 git-rebase--interactive.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 3dc659d..aa2e53c 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -734,6 +734,9 @@ first and then run 'git rebase --continue' again."
 # If you remove a line here THAT COMMIT WILL BE LOST.
 # However, if you remove everything, the rebase will be aborted.
 #
+# If you add a new line with a command followed by the SHA1 ref of the
+# patch, then that patch will be added to the list.
+#
 EOF
 
 		has_action "$TODO" ||
-- 
1.6.1.349.g99fa5

```

## Johannes Schindelin, 2009-02-09 21:31

Subject: Re: [PATCH] git-rebase-interactive: you can also add new commits to the "work list"
Message-ID: <alpine.DEB.1.00.0902092228470.10279@pacific.mpi-cbg.de>
URL: https://gitlist.dev/e/alpine.DEB.1.00.0902092228470.10279%40pacific.mpi-cbg.de
In-Reply-To: <1234214701-20245-1-git-send-email-barvik@broadpark.no>

```
Hi,

On Mon, 9 Feb 2009, Kjetil Barvik wrote:

> Add 2 small lines to document that you can also use 'git rebase
> --interactive' to add new commits to the rebased patch-series.  This
> is sort of running multiple 'git cherry-pick' commands in one go.

If we start along those lines, we also have to add documentation how to

- split commit,

- change authorship of commits,

- deal with commits where --cherry-pick did not detect that they were 
  applied already,

- deal with merge commits, and

- possibly a lot more.

I do not think that this is a good way to spend valuable screen estate; I 
think that is what the man page should cover.

I only made an exception for the deletion of lines, as people were 
actively burnt.  Yes, they should have read the man page.  But the 
consequences of not doing so were bad.

Ciao,
Dscho

```

## Kjetil Barvik, 2009-02-09 21:50

Subject: Re: [PATCH] git-rebase-interactive: you can also add new commits to the "work list"
Message-ID: <86eiy7th3w.fsf@broadpark.no>
URL: https://gitlist.dev/e/86eiy7th3w.fsf%40broadpark.no
In-Reply-To: <alpine.DEB.1.00.0902092228470.10279@pacific.mpi-cbg.de>

```
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

<snipp>
> I do not think that this is a good way to spend valuable screen estate; I 
> think that is what the man page should cover.

  I agree!  Ok, then the correct thing todo whould be to add some lines
  to the git-rebase.txt file in this case.

  -- kjetil

```

## Johannes Schindelin, 2009-02-09 22:26

Subject: Re: [PATCH] git-rebase-interactive: you can also add new commits to the "work list"
Message-ID: <alpine.DEB.1.00.0902092326120.10279@pacific.mpi-cbg.de>
URL: https://gitlist.dev/e/alpine.DEB.1.00.0902092326120.10279%40pacific.mpi-cbg.de
In-Reply-To: <86eiy7th3w.fsf@broadpark.no>

```
Hi,

On Mon, 9 Feb 2009, Kjetil Barvik wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> <snipp>
> > I do not think that this is a good way to spend valuable screen estate; I 
> > think that is what the man page should cover.
> 
>   I agree!  Ok, then the correct thing todo whould be to add some lines
>   to the git-rebase.txt file in this case.

That would be awesome!

Ciao,
Dscho

```