# [PATCH] Make tig call the correct git config command 5 messages from 2009-02-08 to 2009-02-18. Participants: Mikael Magnusson, Jonas Fonseca, Kris Shannon. Thread: https://gitlist.dev/t/17646 ## Mikael Magnusson, 2009-02-08 07:46 Subject: [PATCH] Make tig call the correct git config command Message-ID: <237967ef0902072346x4537f70dua37ba897fac99361@mail.gmail.com> URL: https://gitlist.dev/e/237967ef0902072346x4537f70dua37ba897fac99361%40mail.gmail.com ``` 2009/2/7 Mikael Magnusson : > 2009/2/5 Jonas Fonseca : >> Hello, >> >> Here is a much needed update fixing multiple regressions from the >> introduction of the IO API in 0.13. Among improvements is the much >> requested ability to restore the position in the stage view when staging >> diff hunks. Also noteworthy is the many optimizations of the screen >> updating to make it work better across slow links. Finally, beware that >> a handful of incompatibilities can cause problems. > > I'm having a problem with tig taking 2 seconds to start up, which > seems to be related to the 'typo checking' feature of git. After > figuring out how to stop strace from helpfully saying > write(2, "WARNING: You called a Git program"..., 137) = 137 > I got this (with -s 100): > [pid 29708] write(2, "WARNING: You called a Git program named 'git > config', which does not exist.\nContinuing under the assu"..., 137) = > 137 > [pid 29708] write(2, "in 2.0 seconds automatically...\n"..., 32) = 32 > > The output however also contains lots of git config strings, which is > confusing. Is tig running git config twice and failing one of the > times? (Running git config from the cmdline works fine). Turns out it was as simple as this: diff --git a/configure.ac b/configure.ac index b179389..bdea8de 100644 --- a/configure.ac +++ b/configure.ac @@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config GIT_CONFIG="repo-config" git config --list >/dev/null && GIT_CONFIG="config" AC_MSG_RESULT([$GIT_CONFIG]) -AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[git config subcommand]) +AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[config subcommand]) AC_CHECK_PROGS(ASCIIDOC, [asciidoc false]) AC_CHECK_PROGS(XMLTO, [xmlto false]) -- Mikael Magnusson ``` ## Mikael Magnusson, 2009-02-08 07:49 Subject: Re: [PATCH] Make tig call the correct git config command Message-ID: <237967ef0902072349t784e1519m3561ef02545a72de@mail.gmail.com> URL: https://gitlist.dev/e/237967ef0902072349t784e1519m3561ef02545a72de%40mail.gmail.com In-Reply-To: <237967ef0902072346x4537f70dua37ba897fac99361@mail.gmail.com> ``` As it turns out I'm an idiot, that's just the configure help message. Rerunning autoconf + configure in fact generates a completely correct commandline. Sorry about the noise. 2009/2/8 Mikael Magnusson : > 2009/2/7 Mikael Magnusson : >> 2009/2/5 Jonas Fonseca : >>> Hello, >>> >>> Here is a much needed update fixing multiple regressions from the >>> introduction of the IO API in 0.13. Among improvements is the much >>> requested ability to restore the position in the stage view when staging >>> diff hunks. Also noteworthy is the many optimizations of the screen >>> updating to make it work better across slow links. Finally, beware that >>> a handful of incompatibilities can cause problems. >> >> I'm having a problem with tig taking 2 seconds to start up, which >> seems to be related to the 'typo checking' feature of git. After >> figuring out how to stop strace from helpfully saying >> write(2, "WARNING: You called a Git program"..., 137) = 137 >> I got this (with -s 100): >> [pid 29708] write(2, "WARNING: You called a Git program named 'git >> config', which does not exist.\nContinuing under the assu"..., 137) = >> 137 >> [pid 29708] write(2, "in 2.0 seconds automatically...\n"..., 32) = 32 >> >> The output however also contains lots of git config strings, which is >> confusing. Is tig running git config twice and failing one of the >> times? (Running git config from the cmdline works fine). > > Turns out it was as simple as this: > > diff --git a/configure.ac b/configure.ac > index b179389..bdea8de 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config > GIT_CONFIG="repo-config" > git config --list >/dev/null && GIT_CONFIG="config" > AC_MSG_RESULT([$GIT_CONFIG]) > -AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[git config subcommand]) > +AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[config subcommand]) > > AC_CHECK_PROGS(ASCIIDOC, [asciidoc false]) > AC_CHECK_PROGS(XMLTO, [xmlto false]) > > -- > Mikael Magnusson > -- Mikael Magnusson ``` ## Jonas Fonseca, 2009-02-08 09:56 Subject: Re: [PATCH] Make tig call the correct git config command Message-ID: <2c6b72b30902080156u3b8ba41m736bffaa7b6f15e9@mail.gmail.com> URL: https://gitlist.dev/e/2c6b72b30902080156u3b8ba41m736bffaa7b6f15e9%40mail.gmail.com In-Reply-To: <237967ef0902072349t784e1519m3561ef02545a72de@mail.gmail.com> ``` On Sun, Feb 8, 2009 at 08:49, Mikael Magnusson wrote: > As it turns out I'm an idiot, that's just the configure help message. > Rerunning autoconf + configure in fact generates a completely correct > commandline. Sorry about the noise. Thanks for checking anyway. The Makefile doesn't detect out-of-date configure scripts, which (after the move to use argv arrays and execv in tig-0.13) caused tig to run: "'git' 'git config'" on startup. I wonder if this check in configure should not be removed anyway, since it is starting to be a long time since git-repo-config was renamed. -- Jonas Fonseca ``` ## Kris Shannon, 2009-02-18 11:12 Subject: Re: [PATCH] Make tig call the correct git config command Message-ID: URL: https://gitlist.dev/e/e51f4f550902180312y3e1999e8x5ff119516cd9bbae%40mail.gmail.com In-Reply-To: <2c6b72b30902080156u3b8ba41m736bffaa7b6f15e9@mail.gmail.com> ``` 2009/2/8 Jonas Fonseca > I wonder if this check in configure should not be removed anyway, > since it is starting to be a long time since git-repo-config was > renamed. Speaking from a packaging standpoint, as this is the only reason git-core is a build dependency I would vote to get rid of it. (I currently already patch the configure so I can build without git-core installed) ``` ## Jonas Fonseca, 2009-02-18 11:29 Subject: Re: [PATCH] Make tig call the correct git config command Message-ID: <20090218112914.GA7672@diku.dk> URL: https://gitlist.dev/e/20090218112914.GA7672%40diku.dk In-Reply-To: ``` Kris Shannon wrote Wed, Feb 18, 2009: > 2009/2/8 Jonas Fonseca > > I wonder if this check in configure should not be removed anyway, > > since it is starting to be a long time since git-repo-config was > > renamed. > > Speaking from a packaging standpoint, as this is the only reason > git-core is a build dependency I would vote to get rid of it. > > (I currently already patch the configure so I can build without git-core > installed) Where can I get your patch? -- Jonas Fonseca ```